RUN-85/create developer options fragment #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add Fragment, Viewmodel, navigation to fragment
sergeykamilyevich
requested review from
dmowski,
RybinJD1,
sergey-mikhovich,
Valeria297,
Evgeniy7891 and
VaritskiArseniy
RybinJD1
reviewed
Nov 24, 2022
|
|
||
| @SuppressLint("UnusedMaterialScaffoldPaddingParameter") | ||
| @Composable | ||
| private fun FragmentScaffold(navController: NavController) { |
There was a problem hiding this comment.
название функции не говорящее
There was a problem hiding this comment.
может DeveloperOptionsScreen? мы вчера решили вынести в отдельный файл, я так думаю файл можно назвать DeveloperOptionsScreen, так и функцию назвать, раз она основная будет
RybinJD1
reviewed
Nov 24, 2022
| } | ||
| } | ||
|
|
||
| @SuppressLint("UnusedMaterialScaffoldPaddingParameter") |
There was a problem hiding this comment.
добавил паддинги
add save switchers to SharedPreferences, handle comments
RybinJD1
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание 📝
add Fragment, Viewmodel, navigation to fragment
Скриншоты экранов 📺 🖥