Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML API: Add set/get inner/outer functions #10

Draft
wants to merge 6 commits into
base: trunk
Choose a base branch
from

Conversation

dmsnell
Copy link
Owner

@dmsnell dmsnell commented Aug 14, 2023

This will probably be split before merging. In the process of expanding some comments I discovered that the HTML Processor allows moving forward after finding unsupported HTML, and a new test was added to prevent this. Additionally, it reports a tag name after failing on unsupported HTML, which probably needs to be fixed in the Tag Processor, or through new logic in WP_HTML_Processor::get_tag() to refuse to return results if there's a parse failure. This could get complicated with reporting attributes and all.

@dmsnell dmsnell force-pushed the html-api/add-get-set-inner-outer-contents branch from 6698cd9 to 43db05f Compare August 14, 2023 14:51
@dmsnell dmsnell force-pushed the html-api/add-comments-and-test-case branch from 586b335 to c86eeb2 Compare November 16, 2023 20:39
@dmsnell dmsnell force-pushed the html-api/add-get-set-inner-outer-contents branch from 43db05f to 79bf013 Compare November 16, 2023 20:40
@dmsnell dmsnell changed the base branch from html-api/add-get-set-inner-outer-contents to trunk November 16, 2023 20:54
@dmsnell dmsnell changed the title HTML API: add comments and test case HTML API: Add set/get inner/outer functions Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant