Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests and bugfixes for initial mode support #16

Conversation

sirreal
Copy link
Collaborator

@sirreal sirreal commented Jul 31, 2024

This is work on on initial mode to support html5lib-tests with the full parser and to fix bugs that appear.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@sirreal sirreal marked this pull request as ready for review July 31, 2024 16:52
@sirreal sirreal requested a review from dmsnell July 31, 2024 16:52
Copy link

github-actions bot commented Jul 31, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props dmsnell, jonsurrell.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

dmsnell and others added 16 commits July 31, 2024 16:54
The HTML Processor has only supported a specific kind of parsing mode
called _the fragment parsing mode_, where it behaves in the same way
that `node.innerHTML = html` does in the DOM. This mode assumes a
context node and doesn't support parsing an entire document.

As part of work to add more spec support to the HTML API, this patch
introduces a full parsing mode, which can parse a full HTML document
from start to end, including the doctype declaration and head tags.

Developed in WordPress#6977
Discussed in https://core.trac.wordpress.org/ticket/61576

Props: dmsnell, jonsurrell.
See #61576.


git-svn-id: https://develop.svn.wordpress.org/trunk@58836 602fd350-edb4-49c9-b593-d223f7449a82
Doctypes are not exposed via next_token so cannot be put into the tree
HTML, HEAD, and BODY tags should always be generated.
This breaks many tests. Add the missing tags to the processed tree so tests pass
@sirreal sirreal force-pushed the html-api/support-initial-mode branch from 4a97cab to 1c834ba Compare July 31, 2024 17:33
@sirreal
Copy link
Collaborator Author

sirreal commented Jul 31, 2024

Superseded by WordPress#7117

@sirreal sirreal closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants