Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added validator #7

Merged
merged 2 commits into from
Mar 17, 2023
Merged

added validator #7

merged 2 commits into from
Mar 17, 2023

Conversation

schmunk42
Copy link
Member

Please double-check: @germanbisurgi

@schmunk42 schmunk42 requested a review from eluhr February 1, 2023 13:19
@germanbisurgi
Copy link
Contributor

In composer.json "dmstr/yii2-json-editor": "^1.0.0" should be updated to "dmstr/yii2-json-editor": "^1.4.2" for the HTMLPurifierFilterValidator to be available.

@schmunk42 schmunk42 requested a review from handcode March 17, 2023 08:44
@schmunk42
Copy link
Member Author

@germanbisurgi anything else?

handcode
handcode approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@handcode handcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the HTMLPurifierFilterValidator filter is tested: fine with me

@schmunk42 schmunk42 merged commit a42426a into master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@handcode handcode handcode approved these changes

@eluhr eluhr eluhr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schmunk42 @germanbisurgi @handcode @eluhr