a bit of cleanup, a bit of improvement #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
eluhr
commented
Mar 26, 2019
eluhr
commented
- Switched deprecated methods for new ones.
- Removed unused widget attributes.
- A bit of cleanup
schmunk42
reviewed
Mar 28, 2019
| class AccessInput extends Widget | ||
| { | ||
| public $form; | ||
| public $model; | ||
|
|
||
| public $accessFields = ['owner', 'domain', 'read', 'update', 'delete']; |
There was a problem hiding this comment.
This is not in use currently, but actually the idea was that the widget is configurable regarding which fields are shown.
|
We also need to raise PHP min version in composer.json to 5.5 when using |
|
PHP min version must be raised to 7 due to the usage of the Null Coalescing Operator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.