fix(realClick): only report secondary button being pressed with `butt…

…on: right` (#271)
dmtrKovalenko · Jun 14, 2022 · 0f92778 · 0f92778
1 parent 660025b
commit 0f92778
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/cypress/integration/click.spec.ts b/cypress/integration/click.spec.ts
@@ -64,6 +64,17 @@ describe("cy.realClick", () => {
  .realClick({ clickCount: 2 });
  });
 
+ it("right click should only report secondary button being pressed", () => {
+ cy.get(".navbar-brand").then($navbarBrand => {
+ $navbarBrand.get(0).addEventListener('contextmenu', (ev) => {
+ ev.preventDefault()
+ expect(ev.buttons).to.eq(2)
+ })
+ })
+
+ cy.get('.navbar-brand').realClick({ button: 'right' })
+ });
+
  describe("scroll behavior", () => {
  function getScreenEdges() {
  const cypressAppWindow = window.parent.document.querySelector("iframe")

diff --git a/src/commands/realClick.ts b/src/commands/realClick.ts
@@ -4,6 +4,7 @@ import {
  ScrollBehaviorOptions,
  Position,
 } from "../getCypressElementCoordinates";
+import { mouseButtonNumbers } from "../mouseButtonNumbers";
 
 export interface RealClickOptions {
  /** Pointer type for realClick, if "pen" touch simulated */
@@ -74,7 +75,7 @@ export async function realClick(
  x,
  y,
  clickCount: currentClick,
- buttons: 1,
+ buttons: mouseButtonNumbers[options.button ?? "left"],
  pointerType: options.pointer ?? "mouse",
  button: options.button ?? "left",
  });
@@ -84,7 +85,7 @@ export async function realClick(
  x,
  y,
  clickCount: currentClick,
- buttons: 1,
+ buttons: mouseButtonNumbers[options.button ?? "left"],
  pointerType: options.pointer ?? "mouse",
  button: options.button ?? "left",
  });