refactor: change build to target ES6
#645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 10, 2024
This was referenced Sep 15, 2024
This was referenced Sep 20, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #248
As discussed in the issue,
tslib(Class extending) usage in transpiled code is redundant nowadays as all the major browsers do support ES6, which has native classes support.The concern with the
opera miniin the MUI context is somewhat irrelevant as it was discussed and uncovered that it's basically an error on the MUI side and should be removed as babel ignores it anyways.P.S.: Do note that technically this should be a major bump to signal users, that the new release requires an environment supporting at least ES6.