Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in webshot2::webshot - unused argument (top = FALSE) #21

Closed
psychemedia opened this issue Feb 16, 2021 · 2 comments
Closed

Error in webshot2::webshot - unused argument (top = FALSE) #21

psychemedia opened this issue Feb 16, 2021 · 2 comments

Comments

@psychemedia
Copy link

psychemedia commented Feb 16, 2021 •
edited
Loading

Running rgl::snapshot3d(filename = temp, top = bring_to_front) from rayshader::render_snapshot() or rayshader::render_movie() was working but now throws an error: Error in webshot2::webshot(f1, file = filename, selector = "#webshot", : unused argument (top = FALSE)

3. capture.output(webshot2::webshot(f1, file = filename, selector = "#webshot", vwidth = width + 100, vheight = height, ...), type = "message")

2. rgl::snapshot3d(filename = temp, top = bring_to_front)

1. render_snapshot(hi_quality_fn, samples = 200, top = FALSE, scale_text_size = 24, clear = FALSE)
@psychemedia psychemedia changed the title Error in Error in webshot2::webshot - unused argument (top = FALSE) Feb 16, 2021
@dmurdoch
Copy link
Owner

Yes, I messed up the new params to snapshot3d. Will fix soon. In the meantime, adding webshot = FALSE to the arguments would work around the error (but does require changes to rayshader::render_snapshot).

dmurdoch added a commit that referenced this issue Feb 16, 2021
@dmurdoch
Allow rgl.snapshot args to snapshot3d. Fixes issue #21.
4f29bd5
dmurdoch added a commit that referenced this issue Feb 16, 2021
@dmurdoch
Allow rgl.snapshot args to snapshot3d. Fixes issue #21. (#22)
08d5523
@psychemedia
Copy link
Author

Thanks:-)

dmurdoch added a commit that referenced this issue Mar 3, 2021
@dmurdoch @jeffreyhanson
Merge master into branch (#41)
4cc874e 
* Add drat repository for webshot2

* Fixes to address issues on Solaris, plus some minor stuff (#20)

* Ignore CRAN-RELEASE file

* Allow rgl.snapshot args to snapshot3d.  Fixes issue #21. (#22)

* Protect against missing Pandoc in transparency.Rmd.

* Commit notes etc.

* Remove notes

* Update version number and NEWS

* Fixes issue #27 (#28)

* Ugly workaround for incompatibility with quartz device.  Code to illustrate is

 library(rgl)
 plot(1:10, col=7)
 open3d()

which fails on macOS.

* Additional test for WebGL support, fixes issue #31. (#32)

* Additional test for WebGL support, fixes issue #31.

* add Biarch to DESCRIPTION, fix #19 (#23)

* add Biarch: true to DESCRIPTION, fix issue #19

* Fixes issue #33 : the code for fat lines skipped the wrong entries (#34)

* Fixes issue #33 : the code for fat lines skipped the wrong entries

* Fix lint warning

* Workaround for quartz() device incompatibility (#35)

* Ugly workaround for incompatibility with quartz device.  Code to illustrate is

 library(rgl)
 plot(1:10, col=7)
 open3d()

which fails on macOS.

Allowed R option "rgl.startQuartz" to override the automatic decision, fixed it so it runs on RStudio by default.

* README updates (fixes issue #26)

* Problem building with parallel make (issue #36) (#37)

Fixes error in src/useNULL/Makevars.in that only showed up in parallel makes.

* Get ready for CRAN submission

Co-authored-by: Jeff Hanson <jeffrey.hanson@uqconnect.edu.au>
dmurdoch added a commit that referenced this issue Mar 8, 2021
@dmurdoch @jeffreyhanson
Pkgdown action (#49)
50497d3 
* A start:  inserts the JSON, but doesn't add the assets.

* Merge master into branch (#41)

* Add drat repository for webshot2

* Fixes to address issues on Solaris, plus some minor stuff (#20)

* Ignore CRAN-RELEASE file

* Allow rgl.snapshot args to snapshot3d.  Fixes issue #21. (#22)

* Protect against missing Pandoc in transparency.Rmd.

* Commit notes etc.

* Remove notes

* Update version number and NEWS

* Fixes issue #27 (#28)

* Ugly workaround for incompatibility with quartz device.  Code to illustrate is

 library(rgl)
 plot(1:10, col=7)
 open3d()

which fails on macOS.

* Additional test for WebGL support, fixes issue #31. (#32)

* Additional test for WebGL support, fixes issue #31.

* add Biarch to DESCRIPTION, fix #19 (#23)

* add Biarch: true to DESCRIPTION, fix issue #19

* Fixes issue #33 : the code for fat lines skipped the wrong entries (#34)

* Fixes issue #33 : the code for fat lines skipped the wrong entries

* Fix lint warning

* Workaround for quartz() device incompatibility (#35)

* Ugly workaround for incompatibility with quartz device.  Code to illustrate is

 library(rgl)
 plot(1:10, col=7)
 open3d()

which fails on macOS.

Allowed R option "rgl.startQuartz" to override the automatic decision, fixed it so it runs on RStudio by default.

* README updates (fixes issue #26)

* Problem building with parallel make (issue #36) (#37)

Fixes error in src/useNULL/Makevars.in that only showed up in parallel makes.

* Get ready for CRAN submission

Co-authored-by: Jeff Hanson <jeffrey.hanson@uqconnect.edu.au>

* Some progress, but not working yet.

* Hack to get scripts from the WebGL vignette files.

* Update notes

* Getting closer, but dependencies aren't being handled properly yet.

* Now working with is_low_change etc.

* Fix leakage across example pages, start on reference index

* Updates from master branch, plus changes to avoid check errors

* Updates (skip CI)

* Finish first version of reference page, start on deployment.

* Copy code from other workflow

Co-authored-by: Jeff Hanson <jeffrey.hanson@uqconnect.edu.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@psychemedia @dmurdoch