Fix #8661 changing local account usage to tape recall usage in quota report #8697
Conversation
|
Jenkins results:
|
|
nice work to have "discovered" |
| @@ -29,18 +30,11 @@ def readpwd(): | |||
| def createQuotaReport(rucioClient=None, account=None): | |||
| """ | |||
| create a dictionary with the quota report to be sent to MONIT | |||
| even if we do not report usage at single RSE's now, let's collect that info as well | |||
| returns {'rse1':bytes, 'rse':bytes,..., 'totalTB':TBypte} | |||
| we do not report usage at single RSE's now, we don't collect that info either | |||
There was a problem hiding this comment.
i suggest to remove this comment which was specific of using get_local_account_usage
|
please also fix pylint warnings, even if not due to your changes, let's take chances like this to slowly improve code quality. A campaign to fix all code base is too much, but we should aim for 'all checks passed' as much as possible. So we avoid not noticing new problems amid the existing noise. |
|
Jenkins results:
|
|
generally speaking it is more correct to wait before merging, or the reviewer to check that changes addressed the comments. It is not a good practice to merge with non-approved reviews. |
|
@belforte Sorry for the hurry. As the changes requested were not major, I merged without disturbing you again. I will be more thorough going forward :) |
changing local account usage to tape recall usage in quota report
See #8661