[CRM] Safety check for division by 0 (sonic-net#1569)

Check if divisor is 0. If yes, log warning and skip division
dmytroxshevchuk · Dec 26, 2020 · 41fd2c4 · 41fd2c4
1 parent 9ed3026
commit 41fd2c4
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/orchagent/crmorch.cpp b/orchagent/crmorch.cpp
@@ -541,7 +541,16 @@ void CrmOrch::checkCrmThresholds()
 
  if (cnt.usedCounter != 0)
  {
- percentageUtil = (uint32_t)((cnt.usedCounter * 100) / (uint64_t)(cnt.usedCounter + cnt.availableCounter));
+ uint32_t dvsr = cnt.usedCounter + cnt.availableCounter;
+ if (dvsr != 0)
+ {
+ percentageUtil = (cnt.usedCounter * 100) / dvsr;
+ }
+ else
+ {
+ SWSS_LOG_WARN("%s Exception occured (div by Zero): Used count %u free count %u",
+ res.name.c_str(), cnt.usedCounter, cnt.availableCounter);
+ }
  }
 
  switch (res.thresholdType)