APPS-2549 Bulk describe optimization in scatter-collect to cover files in arrays, structs #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-i-v-a
changed the title
…ers might not match because ids will be converted to set
r-i-v-a
commented
Mar 22, 2024
| @@ -414,7 +418,6 @@ abstract class JobMeta(val workerPaths: DxWorkerPaths, | |||
| if (queryFiles.isEmpty) { | |||
| queryFiles | |||
| } else { | |||
| logger.trace(s"Bulk describing ${queryFiles.size} files") | |||
There was a problem hiding this comment.
This logging is moved to dxApi (other PR).
r-i-v-a
commented
Mar 22, 2024
| } collect { | ||
| case dxFile: DxFile => dxFile | ||
| } flatMap { | ||
| dxApi.flattenDxFileObjectsFromJson |
There was a problem hiding this comment.
The part using the new implementation from dxApi
Gvaihir
reviewed
Mar 22, 2024
There was a problem hiding this comment.
Looks good! In the ticket please:
- Run a WF prior to changes, and provide a splunk stats showing file/describe from dxScala agent. Should be some.
- Run after changes applied showing splunk stats for the same WF (new analysis) and decreased/eliminated dxScala-made file/describe.
done -- APPS-2549 |
r-i-v-a
added
the
cwl_conformance
Gvaihir
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would depend on dxScala change
https://github.com/dnanexus/dxScala/pull/129/files