Skip to content

Commit

Permalink
feat(Modal, Dialog, Drawer): remove closeButtonAttributes (#1926)
Browse files Browse the repository at this point in the history
  • Loading branch information
langz authored and tujoworker committed May 31, 2023
1 parent 41daf74 commit 2dac9cd
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,4 @@
| `spacing` | _(deprecated/optional)_ if set to `false` then the modal content will be shown without any spacing. Defaults to `true`. |
| `closeTitle` / `close_title` | _(deprecated/optional)_ the title of the close button. Defaults to _Lukk_. |
| `hideCloseButton` | _(deprecated/optional)_ if truthy, the close button will not be shown. |
| `closeButtonAttributes` | _(deprecated/optional)_ define any valid Eufemia Button property or HTML attribute inside an object. |
| `class` or `className` | _(deprecated/optional)_ give the inner content wrapper a class name (maps to `dnb-modal__content__inner`). |
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ export default function PortalToolsMenu({
</Tooltip>
),
}}
closeButtonAttributes={{ skeleton: false }}
{...props}
>
<Modal.Content spacing>
Expand Down
2 changes: 0 additions & 2 deletions packages/dnb-eufemia/src/components/dialog/Dialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ function Dialog(
focusSelector,
labelledBy,
directDomReturn,
closeButtonAttributes,
disabled,

variant,
Expand Down Expand Up @@ -108,7 +107,6 @@ function Dialog(
dialogTitle,
closeTitle,
hideCloseButton: currentHideCloseButton,
closeButtonAttributes,
preventClose,
preventOverlayClose: currentPreventOverlayClose,
animationDuration,
Expand Down
2 changes: 0 additions & 2 deletions packages/dnb-eufemia/src/components/drawer/Drawer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ function Drawer({
labelledBy,
directDomReturn,
hideCloseButton,
closeButtonAttributes,
disabled,

title,
Expand Down Expand Up @@ -74,7 +73,6 @@ function Drawer({
dialogTitle,
closeTitle,
hideCloseButton,
closeButtonAttributes,
preventClose,
preventOverlayClose,
animationDuration,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -238,9 +238,6 @@ export const ModalV2Sandbox = () => (
text: 'Custom',
'data-testid': 'html-selector',
}}
closeButtonAttributes={{
'data-testid': 'html-selector',
}}
>
The informational content
</Modal>
Expand Down

0 comments on commit 2dac9cd

Please sign in to comment.