fix(DatePicker): rename testing attributes to data-testid

Also, include a rename in a couple of stories (to safe time).
dnbexperience · Jun 13, 2022 · 2e1e285 · 2e1e285
1 parent c6a2a44
commit 2e1e285
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/packages/dnb-eufemia/src/components/date-picker/DatePickerFooter.js b/packages/dnb-eufemia/src/components/date-picker/DatePickerFooter.js
@@ -116,7 +116,7 @@ export default class DatePickerFooter extends React.PureComponent {
           <Button
             text={submit_button_text}
             onClick={this.onSubmitHandler}
-            data-visual-test="submit"
+            data-testid="submit"
           />
         )) || <span />}
 
@@ -128,7 +128,7 @@ export default class DatePickerFooter extends React.PureComponent {
               icon_position="left"
               variant="tertiary"
               onClick={this.onResetHandler}
-              data-visual-test="reset"
+              data-testid="reset"
             />
           )) || <span />}
 
@@ -139,7 +139,7 @@ export default class DatePickerFooter extends React.PureComponent {
               icon_position="left"
               variant="tertiary"
               onClick={this.onCancelHandler}
-              data-visual-test="cancel"
+              data-testid="cancel"
             />
           )) || <span />}
         </span>

diff --git a/packages/dnb-eufemia/src/components/date-picker/__tests__/DatePicker.test.js b/packages/dnb-eufemia/src/components/date-picker/__tests__/DatePicker.test.js
@@ -309,15 +309,15 @@ describe('DatePicker component', () => {
       />
     )
 
-    const resetElem = Comp.find('button[data-visual-test="reset"]')
+    const resetElem = Comp.find('button[data-testid="reset"]')
     expect(resetElem.exists()).toBe(true)
     expect(resetElem.text()).toMatch('Tilbakestill')
 
-    const cancelElem = Comp.find('button[data-visual-test="cancel"]')
+    const cancelElem = Comp.find('button[data-testid="cancel"]')
     expect(cancelElem.exists()).toBe(true)
     expect(cancelElem.text()).toMatch('Avbryt')
 
-    const submitElem = Comp.find('button[data-visual-test="submit"]')
+    const submitElem = Comp.find('button[data-testid="submit"]')
     expect(submitElem.exists()).toBe(true)
     expect(submitElem.text()).toMatch('Ok')
 
@@ -368,7 +368,7 @@ describe('DatePicker component', () => {
       />
     )
 
-    const resetElem = Comp.find('button[data-visual-test="reset"]')
+    const resetElem = Comp.find('button[data-testid="reset"]')
     expect(resetElem.exists()).toBe(true)
     expect(resetElem.text()).toMatch(reset_button_text)
   })

diff --git a/packages/dnb-eufemia/src/components/dropdown/stories/Dropdown.stories.js b/packages/dnb-eufemia/src/components/dropdown/stories/Dropdown.stories.js
@@ -25,7 +25,7 @@ export default {
 }
 
 const CustomStyle = styled.div`
-  [data-visual-test='dropdown-list'].dnb-drawer-list__list {
+  [data-testid='dropdown-list'].dnb-drawer-list__list {
     display: block;
     visibility: visible;
     position: relative;
@@ -539,7 +539,7 @@ const DropdownStory = () => {
       </Box>
       <Box>
         <span
-          data-visual-test="dropdown-list"
+          data-testid="dropdown-list"
           className="dnb-drawer-list__list"
         >
           <ul className="dnb-drawer-list__options">

diff --git a/packages/dnb-eufemia/src/fragments/drawer-list/stories/DrawerList.stories.js b/packages/dnb-eufemia/src/fragments/drawer-list/stories/DrawerList.stories.js
@@ -20,7 +20,7 @@ const Drawer = styled(DrawerList)`
   margin-bottom: 4rem;
 `
 const CustomStyle = styled.div`
-  [data-visual-test='dropdown-list'].dnb-drawer-list__list {
+  [data-testid='dropdown-list'].dnb-drawer-list__list {
     display: block;
     visibility: visible;
     position: relative;