Skip to content

Commit

Permalink
fix: fix circular dependency issue for Timeline and Avatar
Browse files Browse the repository at this point in the history
- when bundling UMD modules with Rollup.js
  • Loading branch information
tujoworker committed Jan 26, 2022
1 parent cb436d3 commit 439ccc3
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 14 deletions.
5 changes: 1 addition & 4 deletions packages/dnb-eufemia/src/components/avatar/Avatar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { createSpacingClasses } from '../space/SpacingHelper'
import { createSkeletonClass } from '../skeleton/SkeletonHelper'

// Elements
import { ImgProps } from '../../elements/Img'
import Img, { ImgProps } from '../../elements/Img'

// Shared
import Context from '../../shared/Context'
Expand All @@ -15,13 +15,10 @@ import {
extendPropsWithContext,
warn,
} from '../../shared/component-helper'
import { Img } from '../..'

// Internal
import AvatarGroup, { AvatarGroupContext } from './AvatarGroup'

export * from './AvatarGroup'

export type AvatarSizes = 'small' | 'medium' | 'large' | 'x-large'
export type AvatarVariants = 'primary' | 'secondary' | 'tertiary'

Expand Down
8 changes: 0 additions & 8 deletions packages/dnb-eufemia/src/components/avatar/index.d.ts

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { fireEvent, render, screen } from '@testing-library/react'
import Breadcrumb, { BreadcrumbItem } from '../Breadcrumb'
import { Provider } from '../../../shared'
import MatchMediaMock from 'jest-matchmedia-mock'
import { IconPrimary } from '../..'
import IconPrimary from '../../icon-primary/IconPrimary'
import { loadScss, axeComponent } from '../../../core/jest/jestSetup'

const matchMedia = new MatchMediaMock()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React from 'react'
import { render, screen } from '@testing-library/react'
import Timeline, { TimelineItem } from '../Timeline'

import { IconPrimary } from '../..'
import IconPrimary from '../../icon-primary/IconPrimary'
import { loadScss, axeComponent } from '../../../core/jest/jestSetup'

describe('Timeline', () => {
Expand Down

0 comments on commit 439ccc3

Please sign in to comment.