Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
tujoworker committed Nov 22, 2024
1 parent e00633a commit 441616c
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ The `InputPassword` component has been moved to `Field.Password`, and is now a p
- replace Form.Iterate label variable `{itemNr}` with `{itemNo}`.
- replace `Form.FieldProps` with `Field.Provider`.
- replace `<Card stack>...</Card>` with `<Form.Card>...</Form.Card>`.
- replace `<Card>...</Card>` with `<Form.Card>...</Form.Card>`.

## NumberFormat

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,26 +12,26 @@ import * as Examples from './Examples'

### Vertical fields

When you use Eufemia Forms, you may want to use [Form.Card](/uilib/extensions/forms/Form/Card/) instead of the original Card component.
When using Eufemia Forms, you may want to use [Form.Card](/uilib/extensions/forms/Form/Card/) instead of the original Card component.

<Examples.VerticalFields />

### Horizontal fields

When you use Eufemia Forms, you may want to use [Form.Card](/uilib/extensions/forms/Form/Card/) instead of the original Card component.
When using Eufemia Forms, you may want to use [Form.Card](/uilib/extensions/forms/Form/Card/) instead of the original Card component.

<Examples.HorizontalFields />

### Stack

When `stack` is set to `true`, the Card will add a gap between its children and stretch them to the full.

For [form components](uilib/extensions/forms/), you should [Form.Card](/uilib/extensions/forms/Form/Card/) instead of the original Card component.

<Examples.Stack />
For [form components](uilib/extensions/forms/), you should use [Form.Card](/uilib/extensions/forms/Form/Card/) instead of the original Card component.

When `stack` is set to `true`, the Card will add a gap between its children and stretch them to the full.

<Examples.Stack />

### Nested Cards

Nested cards have `responsive={false}` by default and will not behave responsive.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import ComponentBox from '../../../../../../../shared/tags/ComponentBox'

import { Field, Form, Value } from '@dnb/eufemia/src/extensions/forms'

export const ViewAndEditContainer = () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import ComponentBox from '../../../../../../shared/tags/ComponentBox'

import { Field, Form, Iterate } from '@dnb/eufemia/src/extensions/forms'

export const Default = () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React from 'react'
import ComponentBox from '../../../../../../shared/tags/ComponentBox'

import { Field, Form, Value } from '@dnb/eufemia/src/extensions/forms'

export function InheritVisibility() {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import ComponentBox from '../../../../../../shared/tags/ComponentBox'

import { Field, Form, Value } from '@dnb/eufemia/src/extensions/forms'

export const DefaultLayout = () => {
Expand Down

0 comments on commit 441616c

Please sign in to comment.