Skip to content

Commit

Permalink
fix(Dropdown): Missing properties in PropTypes
Browse files Browse the repository at this point in the history
  • Loading branch information
@langz
langz committed Apr 6, 2022
1 parent 1256009 commit 46ebcf3
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 4 deletions.
11 changes: 11 additions & 0 deletions packages/dnb-eufemia/src/components/dropdown/Dropdown.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,13 @@ export default class Dropdown extends React.PureComponent {
disabled: PropTypes.oneOfType([PropTypes.string, PropTypes.bool]),
stretch: PropTypes.oneOfType([PropTypes.string, PropTypes.bool]),
skeleton: PropTypes.oneOfType([PropTypes.string, PropTypes.bool]),
page_offset: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
observer_element: PropTypes.oneOfType([
PropTypes.string,
PropTypes.node,
]),
min_height: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
enable_body_lock: PropTypes.bool,
class: PropTypes.string,

className: PropTypes.string,
Expand Down Expand Up @@ -205,6 +212,10 @@ export default class Dropdown extends React.PureComponent {
disabled: null,
stretch: null,
skeleton: null,
page_offset: null,
observer_element: null,
min_height: null,
enable_body_lock: false,
class: null,

className: null,
Expand Down
22 changes: 18 additions & 4 deletions packages/dnb-eufemia/src/components/dropdown/__tests__/__snapshots__/Dropdown.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ exports[`Dropdown markup have to match snapshot 1`] = `
default_value="default_value"
direction="bottom"
disabled="disabled"
enable_body_lock={true}
focusable="focusable"
global_status_id="main"
icon="icon"
Expand All @@ -74,16 +75,19 @@ exports[`Dropdown markup have to match snapshot 1`] = `
label_direction="horizontal"
label_sr_only="label_sr_only"
max_height={1}
min_height="min_height"
more_menu={null}
no_animation={true}
no_scroll_animation="no_scroll_animation"
observer_element="observer_element"
on_change={[Function]}
on_hide={[Function]}
on_select={[Function]}
on_show={[Function]}
on_state_update={[Function]}
open_on_focus="open_on_focus"
opened={true}
page_offset="page_offset"
portal_class="portal_class"
prevent_close="prevent_close"
prevent_selection={null}
Expand Down Expand Up @@ -166,7 +170,7 @@ exports[`Dropdown markup have to match snapshot 1`] = `
default_value="default_value"
direction="bottom"
disabled="disabled"
enable_body_lock={false}
enable_body_lock={true}
fixed_position={false}
focusable="focusable"
global_status_id="main"
Expand All @@ -184,11 +188,11 @@ exports[`Dropdown markup have to match snapshot 1`] = `
label_sr_only="label_sr_only"
list_class={null}
max_height={1}
min_height={10}
min_height="min_height"
more_menu={null}
no_animation={true}
no_scroll_animation="no_scroll_animation"
observer_element={null}
observer_element="observer_element"
on_change={[Function]}
on_hide={[Function]}
on_pre_change={null}
Expand All @@ -199,7 +203,7 @@ exports[`Dropdown markup have to match snapshot 1`] = `
open_on_focus="open_on_focus"
opened={null}
options_render={null}
page_offset={null}
page_offset="page_offset"
portal_class="portal_class"
prepared_data={null}
prevent_close="prevent_close"
Expand Down Expand Up @@ -288,6 +292,7 @@ exports[`Dropdown markup have to match snapshot 1`] = `
default_value="default_value"
direction="bottom"
disabled="disabled"
enable_body_lock={true}
focusable="focusable"
global_status_id="main"
icon="icon"
Expand All @@ -300,16 +305,19 @@ exports[`Dropdown markup have to match snapshot 1`] = `
label_direction="horizontal"
label_sr_only="label_sr_only"
max_height={1}
min_height="min_height"
more_menu={null}
no_animation={true}
no_scroll_animation="no_scroll_animation"
observer_element="observer_element"
on_change={[Function]}
on_hide={[Function]}
on_select={[Function]}
on_show={[Function]}
on_state_update={[Function]}
open_on_focus="open_on_focus"
opened={true}
page_offset="page_offset"
portal_class="portal_class"
prevent_close="prevent_close"
prevent_selection={null}
Expand Down Expand Up @@ -704,6 +712,7 @@ exports[`Dropdown markup have to match snapshot 1`] = `
default_value="default_value"
direction="bottom"
disabled="disabled"
enable_body_lock={true}
fixed_position={false}
focusable="focusable"
handle_dismiss_focus={null}
Expand Down Expand Up @@ -753,6 +762,7 @@ exports[`Dropdown markup have to match snapshot 1`] = `
default_value="default_value"
direction="bottom"
disabled="disabled"
enable_body_lock={true}
fixed_position={false}
focusable="focusable"
handle_dismiss_focus={null}
Expand Down Expand Up @@ -1268,6 +1278,7 @@ exports[`Dropdown markup have to match snapshot 1`] = `
"default_value": "default_value",
"direction": "bottom",
"disabled": "disabled",
"enable_body_lock": true,
"focusable": "focusable",
"global_status_id": "main",
"icon": "icon",
Expand All @@ -1280,16 +1291,19 @@ exports[`Dropdown markup have to match snapshot 1`] = `
"label_direction": "horizontal",
"label_sr_only": "label_sr_only",
"max_height": 1,
"min_height": "min_height",
"more_menu": null,
"no_animation": true,
"no_scroll_animation": "no_scroll_animation",
"observer_element": "observer_element",
"on_change": [Function],
"on_hide": [Function],
"on_select": [Function],
"on_show": [Function],
"on_state_update": [Function],
"open_on_focus": "open_on_focus",
"opened": true,
"page_offset": "page_offset",
"portal_class": "portal_class",
"prevent_close": "prevent_close",
"prevent_selection": null,
Expand Down

0 comments on commit 46ebcf3

Please sign in to comment.