Skip to content

Commit

Permalink
feat(Typography): change sbanken bold to medium (#2808)
Browse files Browse the repository at this point in the history
Changed all uses of bold to medium in sbanken theme
  • Loading branch information
snorrekim authored Nov 9, 2023
1 parent 1571138 commit 4b0f930
Show file tree
Hide file tree
Showing 137 changed files with 18 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ export function ParagraphRegressionTests() {
}

return (
<ComponentBox scope={{ PWrap }} data-visual-test={'paragraph-sizes'}>
<ComponentBox scope={{ PWrap }} data-visual-test="paragraph-sizes">
<PWrap customSize="default" />
<PWrap size="xx-large" />
<PWrap size="x-large" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ test.describe('Typography for Sbanken', () => {
const element = page
.locator('.typography-box > .dnb-typo-bold')
.first()
await expect(element).toHaveCSS('font-weight', '700')
await expect(element).toHaveCSS('font-weight', '500')
})

test('examples should not have paragraphs inside headings', async ({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ export default {
'--font-weight-default': 'normal',
'--font-weight-basis': 'normal',
'--font-weight-regular': 'normal',
'--font-weight-medium': 'var(--sb-font-weight-bold)',
'--font-weight-bold': '600',
'--font-weight-medium': 'var(--sb-font-weight-medium)',
'--font-weight-bold': 'var(--sb-font-weight-bold)',
'--font-size-x-small': 'var(--sb-font-size-x-small)',
'--font-size-small': 'var(--sb-font-size-small)',
'--font-size-basis': 'var(--sb-font-size-basis)',
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
--accordion-frame-width--active: 0.125rem;

> .dnb-accordion__header {
font-weight: var(--sb-font-weight-bold);
font-weight: var(--font-weight-medium);
}

// disabled
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ exports[`Anchor scss has to match theme css for sbanken 1`] = `
--anchor-underline-thickness: 0.125rem;
--anchor-background: transparent;
--anchor-color--contrast: var(--sb-color-text);
font-weight: var(--sb-font-weight-bold);
font-weight: var(--font-weight-medium);
color: var(--sb-color-gray-dark-3);
text-decoration-color: var(--sb-color-green-dark);
padding: 0.15625em 0;
Expand Down Expand Up @@ -597,7 +597,7 @@ exports[`Anchor scss has to match theme css for sbanken 1`] = `
--anchor-underline-thickness: 0.125rem;
--anchor-background: transparent;
--anchor-color--contrast: var(--sb-color-text);
font-weight: var(--sb-font-weight-bold);
font-weight: var(--font-weight-medium);
color: var(--sb-color-gray-dark-3);
text-decoration-color: var(--sb-color-green-dark);
padding: 0.15625em 0;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@
--anchor-background: transparent;
--anchor-color--contrast: var(--sb-color-text);

// Has to use --sb-font-weight-bold to get correct weighting as --sb-font-weight-medium does nothing at the moment
font-weight: var(--sb-font-weight-bold);
font-weight: var(--font-weight-medium);
color: var(--sb-color-gray-dark-3);
text-decoration-color: var(--sb-color-green-dark);
padding: 0.15625em 0;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
&__th,
& thead th {
padding: 0.5rem 1.5rem 0.25rem;
font-weight: var(--font-weight-medium);
background-color: var(--sb-color-white);
}

Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ export default {
'--font-weight-default': 'normal',
'--font-weight-basis': 'normal',
'--font-weight-regular': 'normal',
'--font-weight-medium': 'var(--sb-font-weight-bold)',
'--font-weight-bold': '600',
'--font-weight-medium': 'var(--sb-font-weight-medium)',
'--font-weight-bold': 'var(--sb-font-weight-bold)',
'--font-size-x-small': 'var(--sb-font-size-x-small)',
'--font-size-small': 'var(--sb-font-size-small)',
'--font-size-basis': 'var(--sb-font-size-basis)',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
--font-family-default: var(--sb-font-family-default);

// font-weight
--font-weight-medium: var(--sb-font-weight-bold);
--font-weight-medium: var(--sb-font-weight-medium);
--font-weight-bold: var(--sb-font-weight-bold);

// font-size
--font-size-x-small: var(--sb-font-size-x-small);
Expand Down

0 comments on commit 4b0f930

Please sign in to comment.