feat(P): deprecate style_type property (#1855)

dnbexperience · Feb 22, 2023 · 74bc0ea · 74bc0ea
1 parent 9af5268
commit 74bc0ea
Show file tree

Hide file tree

Showing 8 changed files with 5 additions and 18 deletions.
diff --git a/.../dnb-eufemia/src/components/global-error/__tests__/__snapshots__/GlobalError.test.js.snap b/.../dnb-eufemia/src/components/global-error/__tests__/__snapshots__/GlobalError.test.js.snap
@@ -1208,7 +1208,6 @@ exports[`GlobalError snapshot have to match component snapshot 1`] = `
           modifier={null}
           size={null}
           small={null}
-          style_type={null}
         >
           <ForwardRef
             as="p"

diff --git a/packages/dnb-eufemia/src/components/skeleton/__tests__/__snapshots__/Skeleton.test.js.snap b/packages/dnb-eufemia/src/components/skeleton/__tests__/__snapshots__/Skeleton.test.js.snap
@@ -50,7 +50,6 @@ exports[`Skeleton component have to match snapshot 1`] = `
             modifier={null}
             size={null}
             small={null}
-            style_type={null}
           >
             <ForwardRef
               as="p"

diff --git a/packages/dnb-eufemia/src/elements/Ingress.js b/packages/dnb-eufemia/src/elements/Ingress.js
@@ -6,6 +6,6 @@
 import React from 'react'
 import P from './P'
 
-const Ingress = (p) => <P style_type="ingress" {...p} />
+const Ingress = (p) => <P className="dnb-p--ingress" {...p} />
 Ingress.tagName = 'dnb-p--ingress'
 export default Ingress
diff --git a/packages/dnb-eufemia/src/elements/Lead.js b/packages/dnb-eufemia/src/elements/Lead.js
@@ -6,6 +6,6 @@
 import React from 'react'
 import P from './P'
 
-const Lead = (p) => <P style_type="lead" {...p} />
+const Lead = (p) => <P className="dnb-p--lead" {...p} />
 Lead.tagName = 'dnb-p--lead'
 export default Lead
diff --git a/packages/dnb-eufemia/src/elements/P.d.ts b/packages/dnb-eufemia/src/elements/P.d.ts
@@ -38,7 +38,6 @@ export interface PProps
   medium?: boolean;
   bold?: boolean;
   size?: PSize;
-  style_type?: string;
   modifier?: string;
   children?: React.ReactNode;
 }

diff --git a/packages/dnb-eufemia/src/elements/P.js b/packages/dnb-eufemia/src/elements/P.js
@@ -10,7 +10,6 @@ import { spacingPropTypes } from '../components/space/SpacingHelper'
 import E from './Element'
 
 const P = ({
-  style_type,
   modifier,
   element,
   className,
@@ -27,10 +26,6 @@ const P = ({
     modifier = [modifier]
   }
 
-  if (style_type) {
-    modifier.push(style_type) // deprecated
-  }
-
   if (medium === true) {
     modifier.push('medium')
   } else if (bold === true) {
@@ -76,7 +71,6 @@ P.propTypes = {
     'x-large',
     'xx-large',
   ]),
-  style_type: PropTypes.string, // deprecated
   modifier: PropTypes.string,
   children: PropTypes.node,
 }
@@ -87,7 +81,6 @@ P.defaultProps = {
   medium: null,
   bold: null,
   size: null,
-  style_type: null, // deprecated
   modifier: null,
   children: null,
 }

diff --git a/packages/dnb-eufemia/src/elements/__tests__/__snapshots__/P.test.js.snap b/packages/dnb-eufemia/src/elements/__tests__/__snapshots__/P.test.js.snap
@@ -9,19 +9,18 @@ exports[`P element have to match default P element snapshot 1`] = `
   modifier="modifier"
   size="x-small"
   small={true}
-  style_type="style_type"
 >
   <ForwardRef
     as="p"
-    className="dnb-p  dnb-p--modifier dnb-p--style_type dnb-p--medium className dnb-p__size--x-small"
+    className="dnb-p  dnb-p--modifier dnb-p--medium className dnb-p__size--x-small"
   >
     <ElementInstance
       as="p"
-      className="dnb-p  dnb-p--modifier dnb-p--style_type dnb-p--medium className dnb-p__size--x-small"
+      className="dnb-p  dnb-p--modifier dnb-p--medium className dnb-p__size--x-small"
       innerRef={null}
     >
       <p
-        className="dnb-p  dnb-p--modifier dnb-p--style_type dnb-p--medium className dnb-p__size--x-small"
+        className="dnb-p  dnb-p--modifier dnb-p--medium className dnb-p__size--x-small"
       >
         children
       </p>

diff --git a/.../dnb-eufemia/src/extensions/payment-card/__tests__/__snapshots__/PaymentCard.test.js.snap b/.../dnb-eufemia/src/extensions/payment-card/__tests__/__snapshots__/PaymentCard.test.js.snap
@@ -229,7 +229,6 @@ exports[`PaymentCard have to match snapshot 1`] = `
                     modifier="x-small bold"
                     size={null}
                     small={null}
-                    style_type={null}
                   >
                     <ForwardRef
                       as="p"
@@ -256,7 +255,6 @@ exports[`PaymentCard have to match snapshot 1`] = `
                     modifier={null}
                     size={null}
                     small={null}
-                    style_type={null}
                   >
                     <ForwardRef
                       as="p"