chore(Button): add test and fix docs (#1556)

dnbexperience · Sep 12, 2022 · a9177d8 · a9177d8
1 parent dde8576
commit a9177d8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/dnb-design-system-portal/src/docs/uilib/components/button/properties.md b/packages/dnb-design-system-portal/src/docs/uilib/components/button/properties.md
@@ -6,7 +6,7 @@ showTabs: true
 
 | Properties                                  | Description                                                                                                                                                                                                                                                            |
 | ------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| `type`                                      | _(optional)_ `button`, `reset` or `submit` for the `type` HTML attribute (default to `button`) .                                                                                                                                                                       |
+| `type`                                      | _(optional)_ `button`, `reset` or `submit` for the `type` HTML attribute. Defaults to `button` for legacy reasons.                                                                                                                                                     |
 | `text` or `children`                        | _(optional)_ the content of the button can be a string or a React Element.                                                                                                                                                                                             |
 | `title`                                     | _(optional)_ title of the button. Optional, but should always be included because of accessibility.                                                                                                                                                                    |
 | `variant`                                   | _(optional)_ defines the kind of button. Possible values are `primary`, `secondary`, `tertiary` and `signal`. Defaults to `primary`.                                                                                                                                   |

diff --git a/packages/dnb-eufemia/src/components/button/__tests__/Button.test.js b/packages/dnb-eufemia/src/components/button/__tests__/Button.test.js
@@ -120,6 +120,14 @@ describe('Button component', () => {
     expect(Comp.find('button').instance().hasAttribute('type')).toBe(false)
   })
 
+  it('should use span element if defined', () => {
+    const Comp = mount(<Component element="span" />)
+    expect(Comp.find('.dnb-button').instance().tagName).toBe('SPAN')
+    expect(Comp.find('.dnb-button').instance().getAttribute('type')).toBe(
+      'button'
+    )
+  })
+
   it('has "on_click" event which will trigger on a click', () => {
     const my_event = jest.fn()
     const myEvent = jest.fn()