Skip to content

Commit

Permalink
feat(Icons): add new icons handshake, heavy_equipment, id_card,…
Browse files Browse the repository at this point in the history
… `investment_account`, `keyfigures`, `portfolio_analytics`, `sea_transport`, `shield_lock`, `file_zip`, `bus`, `building_shopping`, `handshake`, `heavy_equipment` (#2178)

* chore: double the wait time on icons lib processing

* feat(Icons): add new icons `handshake`, `heavy_equipment`, `id_card`, `investment_account`, `keyfigures`, `portfolio_analytics`, `sea_transport`, `shield_lock`, `file_zip`, `bus`, `building_shopping`, `handshake`, `heavy_equipment`

* Refactor and update visual snapshots

* Also run e2e visual tests on icons – even if its a double
  • Loading branch information
tujoworker authored and langz committed May 31, 2023
1 parent 2a11261 commit d29447e
Show file tree
Hide file tree
Showing 254 changed files with 2,574 additions and 1,310 deletions.
1 change: 0 additions & 1 deletion .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ on:
- '!**--skip-ci'
- '!**--visual-reports'
- '!wip/**'
- '!icon*/**'
- '!experiments/**'
- '!release'
- '!portal'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/icons-lib.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ jobs:
checkName: Fetch and Build Icons # Has to be the action name
ref: ${{ github.event.pull_request.head.sha || github.sha }}
intervalSeconds: 10
timeoutSeconds: 1200
timeoutSeconds: 2400

- name: Re-store portal artifacts
uses: actions/download-artifact@v3
Expand Down
17 changes: 15 additions & 2 deletions packages/dnb-design-system-portal/src/docs/EUFEMIA_CHANGELOG.mdx
Original file line number Diff line number Diff line change
@@ -1,9 +1,22 @@
## February, 20. 2023
## April, 20. 2023

- [New major version 10](/uilib/about-the-lib/releases/eufemia/v10-info/)
- New components released:
- [SkipContent](/uilib/components/skip-content)
- Removed `style_type` property of [Skeleton](https://eufemia.dnb.no/uilib/components/skeleton)
- New [Icons](/icons/secondary):
- `handshake`
- `heavy_equipment`
- `id_card`
- `investment_account`
- `keyfigures`
- `portfolio_analytics`
- `sea_transport`
- `shield_lock`
- `file_zip`
- `bus`
- `building_shopping`
- `handshake`
- `heavy_equipment`

## November, 22. 2022

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ You may also have a look at the [<Icon icon={GithubLogo} size="default" /> **Git

Here you find an overview of all major releases (versions) and changes, including migration guides:

- [**@dnb/eufemia@v10**](/uilib/about-the-lib/releases/eufemia/v10-info) _February, 24. 2023_
- [**@dnb/eufemia@v10**](/uilib/about-the-lib/releases/eufemia/v10-info) _April, 20. 2023_
- [**@dnb/eufemia@v9**](/uilib/about-the-lib/releases/eufemia/v9-info) _March, 3. 2021_
- [**dnb-ui-lib@v8**](/uilib/about-the-lib/releases/dnb-ui-lib/v8-info) _December, 15. 2020_
- [**dnb-ui-lib@v7.2**](/uilib/about-the-lib/releases/dnb-ui-lib/v7.2-info) _November, 8. 2020_
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -249,4 +249,4 @@ $ npm i @dnb/eufemia@10
$ yarn add @dnb/eufemia@10
```

_February, 24. 2023_
_April, 20. 2023_
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export const IconInheritSized = () => (
)

export const IconMedium = () => {
if (!global.IS_TEST) {
if (!globalThis.IS_TEST) {
return null
}

Expand All @@ -78,8 +78,8 @@ export const IconMedium = () => {
)
}

export const IconPrimaryTest = () => {
if (!global.IS_TEST) {
export const AllPrimaryIcons = () => {
if (!globalThis.IS_TEST) {
return null
}

Expand Down Expand Up @@ -113,8 +113,8 @@ export const IconPrimaryTest = () => {
)
}

export const IconSecondary = () => {
if (!global.IS_TEST) {
export const AllSecondaryIcons = () => {
if (!globalThis.IS_TEST) {
return null
}

Expand Down Expand Up @@ -154,16 +154,6 @@ export const IconSecondary = () => {
)
}

export default function IconTests() {
return (
<>
<IconMedium />
<IconPrimaryTest />
<IconSecondary />
</>
)
}

export const IconColors = () => {
return (
<ComponentBox data-visual-test="icon-colors" scope={{ BellMedium }}>
Expand All @@ -177,3 +167,12 @@ export const IconColors = () => {
</ComponentBox>
)
}

export function AllIconsTest() {
return (
<>
<AllPrimaryIcons />
<AllSecondaryIcons />
</>
)
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
showTabs: true
---

import IconTests, {
import {
IconDefault,
IconBorder,
IconInheritSized,
Expand All @@ -28,5 +28,3 @@ import IconTests, {
All of these methods will output the same color

<IconColors />

<IconTests />
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
draft: true
---

import {
IconMedium,
AllIconsTest,
} from 'Docs/uilib/components/icon/Examples'

<IconMedium />

<AllIconsTest />
2 changes: 1 addition & 1 deletion packages/dnb-eufemia/assets/icons/above_the_line.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/dnb-eufemia/assets/icons/account_card.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/dnb-eufemia/assets/icons/account_in_medium.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/dnb-eufemia/assets/icons/account_out_medium.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/dnb-eufemia/assets/icons/account_percent.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/dnb-eufemia/assets/icons/arrow_down.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/dnb-eufemia/assets/icons/arrow_down_medium.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/dnb-eufemia/assets/icons/arrow_up.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit d29447e

Please sign in to comment.