Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Timeline component #1186

Merged
merged 1 commit into from
Jan 18, 2022
Merged

feat: Timeline component #1186

merged 1 commit into from
Jan 18, 2022

Conversation

langz
Copy link
Contributor

@langz langz commented Dec 28, 2021 •
edited
Loading

@langz langz force-pushed the feat/timeline-component branch from 8ab08f9 to 82c89ca Compare December 28, 2021 15:10
@langz

This comment has been minimized.

Sign in to view
@gatsby-cloud
Copy link

gatsby-cloud bot commented Dec 28, 2021 •
edited
Loading

Gatsby Cloud Build Report

DNB Eufemia Portal

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 8m

Performance

Lighthouse report

Metric Score
Performance 🔶 63
Accessibility 💚 100
Best Practices 💚 100
SEO 💚 92

🔗 View full report

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 28, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0169d87:

Sandbox Source
eufemia-starter Configuration

@langz langz force-pushed the feat/timeline-component branch from 82c89ca to ac15141 Compare December 28, 2021 19:32
@thaytharma
Copy link
Contributor

Awsome work, looks great! @langz 👏 ⭐

@langz langz changed the title Timeline component feat: Timeline component Jan 3, 2022
@langz langz force-pushed the feat/timeline-component branch 3 times, most recently from 4f7e08a to 0146499 Compare January 5, 2022 15:00
@langz

This comment has been minimized.

Sign in to view
@langz langz force-pushed the feat/timeline-component branch from 0146499 to dd1cee7 Compare January 5, 2022 15:13
@langz langz marked this pull request as ready for review January 5, 2022 15:14
@langz langz force-pushed the feat/timeline-component branch 6 times, most recently from 356d40f to 503bbd8 Compare January 5, 2022 19:34
@langz
Copy link
Contributor Author

langz commented Jan 5, 2022 •
edited
Loading

image

As of now the component TimelineItem has the following 3 properties:

  • name (Completed event)
  • date (10. september 2021)
  • info_message (Additional information about this step if needed.)

Maybe I should rename name to title, and date to subtitle? 🤔
I've also considered changing info_message to children so that we could pass anything, but I've dropped that for now, as Casper and I think that's a bit too flexible as of now, and that info message is the only use case we know of as of now.

@langz langz requested a review from tujoworker January 6, 2022 19:38
langz
langz commented Jan 7, 2022
View reviewed changes
packages/dnb-design-system-portal/src/docs/uilib/components/timeline.md
title: 'Timeline'
description: 'The Timeline component shows events in chronological order and gives a great overview of the overall process'
status: 'new'
order: 19
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not 100% sure about the value here.
I see a few components have the same value, others have a unique value.

tujoworker
tujoworker approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work – again!

For new components, you can use safely use camelCase – if you wish? e.g. info_message => infoMessage

@langz
Copy link
Contributor Author

langz commented Jan 11, 2022 •
edited
Loading

Awesome work – again!

For new components, you can use safely use camelCase – if you wish? e.g. info_message => infoMessage

Aha, yeah I see that https://eufemia.dnb.no/uilib/components/breadcrumb/properties use camelCase as well.
I'll change that now.

EDIT: Done ✅

info_message => infoMessage
icon_alt => iconAlt

@langz langz force-pushed the feat/timeline-component branch from 503bbd8 to 6c87aaa Compare January 11, 2022 14:21
@langz langz force-pushed the feat/timeline-component branch from 6c87aaa to 0169d87 Compare January 13, 2022 11:01
@langz langz merged commit 255a14e into main Jan 18, 2022
@langz langz deleted the feat/timeline-component branch January 18, 2022 12:16
tujoworker pushed a commit that referenced this pull request Jan 26, 2022
@semantic-release-bot
chore(release): 9.19.0 [skip ci]
6e58d85 
# [9.19.0](v9.18.0...v9.19.0) (2022-01-26)

### Bug Fixes

* add "unstyled" as a button variant ([8cb0712](8cb0712))
* added export of Bar in Pagination ([#1200](#1200)) ([f148786](f148786))
* **Avatar:** improve accessibility ([#1213](#1213)) ([3a456c5](3a456c5))
* **Breadcrumb:** forward props in BreadcrumbItem to span as well ([#1188](#1188)) ([17a1de0](17a1de0))
* **Breadcrumb:** improve accessibility ([#1189](#1189)) ([59825b8](59825b8))
* **build:** break build when step fails ([cb436d3](cb436d3))
* **CodeHighlighting:** ensure a scrollbar is shown when not enough space is available ([634df1b](634df1b))
* **DrawerList:** ensure DrawerList is unsetting its global attributes on unmount ([d64ccf8](d64ccf8))
* fix circular dependency issue for Timeline and Avatar ([439ccc3](439ccc3))
* fix rendering of DatePickerFooter when show_reset_button is provided ([#1197](#1197)) ([d7d4507](d7d4507))
* fix reset_button_text property of DatePicker ([#1196](#1196)) ([e50fb6f](e50fb6f))
* fixed global context bug that removed component props ([#1193](#1193)) ([82be98c](82be98c))
* **Tag:** fix circular dependency issue when bundling UMD modules with Rollup.js ([d155f7c](d155f7c))
* **Tag:** remove data-prop from TagGroup ([#1225](#1225)) ([72e4207](72e4207))
* **Tag:** remove tag group warnings in tests ([#1214](#1214)) ([16bd840](16bd840))
* **Tag:** update delete icon ([#1224](#1224)) ([fe5c766](fe5c766))

### Features

* add Avatar component ([#1191](#1191)) ([6a30523](6a30523))
* add AvatarGroup component ([#1195](#1195)) ([ae5ef7d](ae5ef7d))
* add InfoCard component ([5db0cbc](5db0cbc))
* add TagGroup component ([#1208](#1208)) ([781007d](781007d))
* add TimeLine component ([#1186](#1186)) ([255a14e](255a14e))
* remove type="module" in order omit the "fullySpecified" spec ([b424e08](b424e08))
* **Tag:** Add onClick prop ([db68b30](db68b30))
* **Tag:** add onDelete-prop ([#1217](#1217)) ([2f1642b](2f1642b))
@tujoworker
Copy link
Member

🎉 This PR is included in version 9.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaytharma thaytharma thaytharma left review comments

@tujoworker tujoworker tujoworker approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@langz @thaytharma @tujoworker