-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add AvatarGroup component #1195
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c18cdd5:
|
Gatsby Cloud Build ReportDNB Eufemia Portal 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 8m PerformanceLighthouse report
|
1d5f278
to
f5d4138
Compare
f5d4138
to
975029f
Compare
} = extendPropsWithContext( | ||
{ ...defaultProps, ...localProps }, | ||
defaultProps, | ||
context?.Avatar |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
.dnb-avatar { | ||
box-sizing: content-box; | ||
|
||
// size small |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
d68f74b
to
7e10bd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me 🙏
7e10bd3
to
48774d9
Compare
| ------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| `size` | _(optional)_ Size of the Avatars, and "elements hidden text (+x)". Options: `small` \| `medium` \| `large` \| `x-large`. Defaults to `medium`. | | ||
| `variant` | _(optional)_ Override the variant of the Avatars. Options: `primary` \| `secondary` \| `tertiary`. Defaults to `primary`. | | ||
| `maxElements` | _(optional)_ Number of max displayed elements, including the "elements hidden text (+x)". | |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks great! 🚀
48774d9
to
18b2244
Compare
18b2244
to
c18cdd5
Compare
# [9.19.0](v9.18.0...v9.19.0) (2022-01-26) ### Bug Fixes * add "unstyled" as a button variant ([8cb0712](8cb0712)) * added export of Bar in Pagination ([#1200](#1200)) ([f148786](f148786)) * **Avatar:** improve accessibility ([#1213](#1213)) ([3a456c5](3a456c5)) * **Breadcrumb:** forward props in BreadcrumbItem to span as well ([#1188](#1188)) ([17a1de0](17a1de0)) * **Breadcrumb:** improve accessibility ([#1189](#1189)) ([59825b8](59825b8)) * **build:** break build when step fails ([cb436d3](cb436d3)) * **CodeHighlighting:** ensure a scrollbar is shown when not enough space is available ([634df1b](634df1b)) * **DrawerList:** ensure DrawerList is unsetting its global attributes on unmount ([d64ccf8](d64ccf8)) * fix circular dependency issue for Timeline and Avatar ([439ccc3](439ccc3)) * fix rendering of DatePickerFooter when show_reset_button is provided ([#1197](#1197)) ([d7d4507](d7d4507)) * fix reset_button_text property of DatePicker ([#1196](#1196)) ([e50fb6f](e50fb6f)) * fixed global context bug that removed component props ([#1193](#1193)) ([82be98c](82be98c)) * **Tag:** fix circular dependency issue when bundling UMD modules with Rollup.js ([d155f7c](d155f7c)) * **Tag:** remove data-prop from TagGroup ([#1225](#1225)) ([72e4207](72e4207)) * **Tag:** remove tag group warnings in tests ([#1214](#1214)) ([16bd840](16bd840)) * **Tag:** update delete icon ([#1224](#1224)) ([fe5c766](fe5c766)) ### Features * add Avatar component ([#1191](#1191)) ([6a30523](6a30523)) * add AvatarGroup component ([#1195](#1195)) ([ae5ef7d](ae5ef7d)) * add InfoCard component ([5db0cbc](5db0cbc)) * add TagGroup component ([#1208](#1208)) ([781007d](781007d)) * add TimeLine component ([#1186](#1186)) ([255a14e](255a14e)) * remove type="module" in order omit the "fullySpecified" spec ([b424e08](b424e08)) * **Tag:** Add onClick prop ([db68b30](db68b30)) * **Tag:** add onDelete-prop ([#1217](#1217)) ([2f1642b](2f1642b))
🎉 This PR is included in version 9.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR adds the AvatarGroup component, which tries to nicely group and style the grouping of the avatars.
Take a look here https://eufemia-featavatargroup.gtsb.io/uilib/components/avatar#grouping-avatars