Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add AvatarGroup component #1195

Merged
merged 1 commit into from
Jan 21, 2022
Merged

feat: add AvatarGroup component #1195

merged 1 commit into from
Jan 21, 2022

Conversation

langz
Copy link
Contributor

@langz langz commented Jan 13, 2022

This PR adds the AvatarGroup component, which tries to nicely group and style the grouping of the avatars.
Take a look here https://eufemia-featavatargroup.gtsb.io/uilib/components/avatar#grouping-avatars

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 13, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c18cdd5:

Sandbox Source
eufemia-starter Configuration

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jan 13, 2022

Gatsby Cloud Build Report

DNB Eufemia Portal

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 8m

Performance

Lighthouse report

Metric Score
Performance 🔶 66
Accessibility 💚 100
Best Practices 💚 100
SEO 💚 92

🔗 View full report

@langz langz force-pushed the feat/avatar-group branch 2 times, most recently from 1d5f278 to f5d4138 Compare January 14, 2022 13:47
@langz langz marked this pull request as ready for review January 14, 2022 13:49
@langz langz changed the title [WIP] feat: add AvatarGroup component feat: add AvatarGroup component Jan 14, 2022
@langz langz force-pushed the feat/avatar-group branch from f5d4138 to 975029f Compare January 17, 2022 08:37
} = extendPropsWithContext(
{ ...defaultProps, ...localProps },
defaultProps,
context?.Avatar

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

.dnb-avatar {
box-sizing: content-box;

// size small

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

@langz langz force-pushed the feat/avatar-group branch 3 times, most recently from d68f74b to 7e10bd3 Compare January 20, 2022 07:20
Copy link
Contributor Author

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me 🙏

@langz langz force-pushed the feat/avatar-group branch from 7e10bd3 to 48774d9 Compare January 20, 2022 08:08
| ------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------- |
| `size` | _(optional)_ Size of the Avatars, and "elements hidden text (+x)". Options: `small` \| `medium` \| `large` \| `x-large`. Defaults to `medium`. |
| `variant` | _(optional)_ Override the variant of the Avatars. Options: `primary` \| `secondary` \| `tertiary`. Defaults to `primary`. |
| `maxElements` | _(optional)_ Number of max displayed elements, including the "elements hidden text (+x)". |

This comment was marked as resolved.

Copy link
Contributor

@thaytharma thaytharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks great! 🚀

@langz langz force-pushed the feat/avatar-group branch from 48774d9 to 18b2244 Compare January 20, 2022 13:49
@langz langz force-pushed the feat/avatar-group branch from 18b2244 to c18cdd5 Compare January 20, 2022 15:01
@langz langz merged commit ae5ef7d into main Jan 21, 2022
@tujoworker tujoworker deleted the feat/avatar-group branch January 25, 2022 07:56
tujoworker pushed a commit that referenced this pull request Jan 26, 2022
# [9.19.0](v9.18.0...v9.19.0) (2022-01-26)

### Bug Fixes

* add "unstyled" as a button variant ([8cb0712](8cb0712))
* added export of Bar in Pagination ([#1200](#1200)) ([f148786](f148786))
* **Avatar:** improve accessibility ([#1213](#1213)) ([3a456c5](3a456c5))
* **Breadcrumb:** forward props in BreadcrumbItem to span as well ([#1188](#1188)) ([17a1de0](17a1de0))
* **Breadcrumb:** improve accessibility ([#1189](#1189)) ([59825b8](59825b8))
* **build:** break build when step fails ([cb436d3](cb436d3))
* **CodeHighlighting:** ensure a scrollbar is shown when not enough space is available ([634df1b](634df1b))
* **DrawerList:** ensure DrawerList is unsetting its global attributes on unmount ([d64ccf8](d64ccf8))
* fix circular dependency issue for Timeline and Avatar ([439ccc3](439ccc3))
* fix rendering of DatePickerFooter when show_reset_button is provided ([#1197](#1197)) ([d7d4507](d7d4507))
* fix reset_button_text property of DatePicker ([#1196](#1196)) ([e50fb6f](e50fb6f))
* fixed global context bug that removed component props ([#1193](#1193)) ([82be98c](82be98c))
* **Tag:** fix circular dependency issue when bundling UMD modules with Rollup.js ([d155f7c](d155f7c))
* **Tag:** remove data-prop from TagGroup ([#1225](#1225)) ([72e4207](72e4207))
* **Tag:** remove tag group warnings in tests ([#1214](#1214)) ([16bd840](16bd840))
* **Tag:** update delete icon ([#1224](#1224)) ([fe5c766](fe5c766))

### Features

* add Avatar component ([#1191](#1191)) ([6a30523](6a30523))
* add AvatarGroup component ([#1195](#1195)) ([ae5ef7d](ae5ef7d))
* add InfoCard component ([5db0cbc](5db0cbc))
* add TagGroup component ([#1208](#1208)) ([781007d](781007d))
* add TimeLine component ([#1186](#1186)) ([255a14e](255a14e))
* remove type="module" in order omit the "fullySpecified" spec ([b424e08](b424e08))
* **Tag:** Add onClick prop ([db68b30](db68b30))
* **Tag:** add onDelete-prop ([#1217](#1217)) ([2f1642b](2f1642b))
@tujoworker
Copy link
Member

🎉 This PR is included in version 9.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants