fix(Button): support target property #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was it so that I need to generate/add this change to |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 980a48c:
|
langz
force-pushed
the
fix/button-should-support-target-prop
branch
from
ff4024e to
42c89c6
Compare
✅ DNB Eufemia Portal deploy preview ready
|
tujoworker
approved these changes
Dec 15, 2022
tujoworker
pushed a commit
that referenced
this pull request
Dec 19, 2022
# [9.43.0](v9.42.0...v9.43.0) (2022-12-19) ### Bug Fixes * **Button:** support target property ([#1817](#1817)) ([71f5ee3](71f5ee3)) * **TableContainer:** align always visible scrollbar ([#1819](#1819)) ([c16519d](c16519d)) * **TableContainer:** no space on empty foot + clip scrollbar ([#1827](#1827)) ([04dd93b](04dd93b)) * **Table:** prevent expanded row to not change column width ([#1816](#1816)) ([bbf94a8](bbf94a8)) * **useHandleSortState:** change default direction from asc to off ([#1826](#1826)) ([c7e4d6f](c7e4d6f)) * **useHandleSortState:** fix import issue ([#1823](#1823)) ([c595ff1](c595ff1)) ### Features * **Scrollbar:** add new look to scrollbars ([#1815](#1815)) ([a590b50](a590b50))
|
🎉 This PR is included in version 9.43.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
joakbjerk
pushed a commit
that referenced
this pull request
Mar 27, 2023
* fix(Button): support target property * Add target to the type definition file Co-authored-by: Tobias Høegh <tobias@tujo.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding documentation and "TypeScript support" for the
targetproperty.Here's an example of when consumers using TypeScript, tries to use the Button component with the
targetproperty as of today(pre this PR):