-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Button): support rel property #1990
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 961ee4e:
|
✅ DNB Eufemia Portal deploy preview ready
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot Anders!🤘🏼🤘🏼
# [9.48.0-beta.1](v9.47.1...v9.48.0-beta.1) (2023-02-23) ### Bug Fixes * **Anchor:** comments Anchor's inner_ref usage ([#1919](#1919)) ([7653316](7653316)) * **Autocomplete:** pass status props to SubmitButton ([#2004](#2004)) ([fb89114](fb89114)) * **Badge:** enhance semantic / accessibility and inherit skeleton from provider ([#1967](#1967)) ([5a870a7](5a870a7)) * **Button:** remove left and right padding of tertiary button ([5919c79](5919c79)) * **Button:** support rel property ([#1990](#1990)) ([ad029f2](ad029f2)) * **Dl:** ensure horizontal wrap no matter what available space ([#1965](#1965)) ([ab15893](ab15893)) * fix breadcumb alignment after tertiary button changes ([2989af1](2989af1)) * fix pagination alignment after tertiary button changes ([ce6e5ea](ce6e5ea)) * **InfoCard:** enhance accessibility + set max width of 60ch ([#1977](#1977)) ([5a4f344](5a4f344)) * remove `maintained node versions` from .browserslistrc ([#1917](#1917)) ([9cb43c4](9cb43c4)), closes [#1912](#1912) * **Timeline:** use ordered list element ([#1962](#1962)) ([2b77b8e](2b77b8e)) * upgrade Stylelint from v13 to v15 ([#1995](#1995)) ([21a1cdb](21a1cdb)) * remove web components and vue support (#1946) ([baa4ca3](baa4ca3)), closes [#1946](#1946) * re-define Media Query Breakpoints and layout width (#1373) ([73d1b77](73d1b77)), closes [#1373](#1373) * v10 ([514becd](514becd)) ### Features * **Anchor:** deprecate property target_blank_title ([#1882](#1882)) ([8c6448d](8c6448d)) * build pure component css packages (without deps) ([#1928](#1928)) ([5a7e111](5a7e111)) * **build:** replace node-sass with dart-sass ([#1934](#1934)) ([ba3fed2](ba3fed2)) * **Checkbox:** deprecate default_state property ([#1863](#1863)) ([e5fb21e](e5fb21e)) * deprecate StepIndicator v1 ([#1840](#1840)) ([c0d9518](c0d9518)) * **DrawerList:** remove use_drawer_on_mobile & enable_closest_observer ([#1879](#1879)) ([e56c925](e56c925)) * **Dropdown:** remove deprecated selected_item property ([#1870](#1870)) ([5321b3a](5321b3a)) * **Element:** deprecate css, class, inner_ref, skeleton_method ([#1859](#1859)) ([7b9554d](7b9554d)) * **FormRow:** remove indent feature ([#1975](#1975)) ([5c58e39](5c58e39)) * **FormStatus:** remove deprecated status property ([#1914](#1914)) ([3c867b5](3c867b5)) * **GlobalStatus:** deprecate AddStatus & Set ([#1891](#1891)) ([bf382fd](bf382fd)) * **H:** deprecate is and style_type properties ([#1856](#1856)) ([c9fb5a6](c9fb5a6)) * **Helpers:** deprecate .dnb-sr-only--inline & .dnb-not-sr-only ([#1865](#1865)) ([d84a49f](d84a49f)) * include all type definitions in repo ([#1996](#1996)) ([3a93c5a](3a93c5a)) * **InputMasked:** ATTENTION! make allowLeadingZeroes default to true ([#1126](#1126)) ([bb2edca](bb2edca)) * **Modal, Dialog, Drawer:** remove closeButtonAttributes ([#1926](#1926)) ([82cd99d](82cd99d)) * **Modal:** remove deprecated mode prop ([#1993](#1993)) ([86c8adc](86c8adc)) * **Modal:** remove deprecated trigger_ props ([#1918](#1918)) ([2eced1b](2eced1b)) * new browserslist config for es6 builds ([#1833](#1833)) ([ab57b84](ab57b84)) * **Number:** Removes component ([#1924](#1924)) ([aeaadc0](aeaadc0)) * **P:** deprecate style_type property ([#1855](#1855)) ([74bc0ea](74bc0ea)) * **P:** remove deprecated class dnb-p--ingress ([#1872](#1872)) ([04e4632](04e4632)) * remove support for internet explorer ([#1807](#1807)) ([fbfd636](fbfd636)) * replace visual test driver to jest-image-snapshot and Firefox (Playwright) ([#1945](#1945)) ([fcc9348](fcc9348)), closes [/github.com/puppeteer/puppeteer/issues/7514#issuecomment-1005917527](https://github.com//github.com/puppeteer/puppeteer/issues/7514/issues/issuecomment-1005917527) [/github.com/dnbexperience/eufemia/blob/88279d1e6903497fce40d6c4322dd9b7c7b9ac3b/packages/dnb-eufemia/src/core/jest/jestSetupScreenshots.js#L39](https://github.com//github.com/dnbexperience/eufemia/blob/88279d1e6903497fce40d6c4322dd9b7c7b9ac3b/packages/dnb-eufemia/src/core/jest/jestSetupScreenshots.js/issues/L39) * **ScrollView:** add interactive=auto to observe the content ([#1984](#1984)) ([988390c](988390c)) * **Section:** deprecate style_type signal-orange ([#1886](#1886)) ([661d976](661d976)) * **SkipContent:** add new component to skip large contents when using tab key ([#1981](#1981)) ([c44ef28](c44ef28)) * **Slider:** deprecate use_scrollwheel ([#1889](#1889)) ([639df46](639df46)) * **Slider:** remove deprecated onInit prop ([#1909](#1909)) ([0595a53](0595a53)) * **Slider:** remove dnb-range styling ([#1890](#1890)) ([1d2693c](1d2693c)) * **Space:** add conditional reset class: `dnb-space__reset` ([#1961](#1961)) ([a79bb2a](a79bb2a)) * **SpacingUtils:** deprecate createStyleObject ([#1892](#1892)) ([cadf378](cadf378)) * **Switch:** deprecate default_state property ([#1864](#1864)) ([da2c568](da2c568)) * **Table:** deprecate sticky_offset ([#1883](#1883)) ([5a242a1](5a242a1)) * **Tags:** removed deprecated comments ([#1857](#1857)) ([9af5268](9af5268)) * **Timeline:** deprecate name and date props ([#1884](#1884)) ([a95db13](a95db13)) * **Typography:** removed deprecated comments ([#1858](#1858)) ([1fd2b48](1fd2b48)) ### Reverts * Revert "chore(Table): remove deprecated selectors (#1902)" (#1968) ([b43bb4f](b43bb4f)), closes [#1902](#1902) [#1968](#1968) ### BREAKING CHANGES * **Modal:** - Modal: Remove deprecated `mode` prop – it will default to `custom` mode. Use rather the `Dialog` or the `Drawer` component. * Remove support for Web Components and Vue * re-define Media Query Breakpoints and layout width * Read the docs about migration: https://eufemia.dnb.no/uilib/about-the-lib/releases/eufemia/v10-info
🎉 This PR is included in version 9.48.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [9.48.0-beta.1](v9.47.1...v9.48.0-beta.1) (2023-02-23) ### ⚠ BREAKING CHANGES * **Modal:** - Modal: Remove deprecated `mode` prop – it will default to `custom` mode. Use rather the `Dialog` or the `Drawer` component. * Remove support for Web Components and Vue * re-define Media Query Breakpoints and layout width * Read the docs about migration: https://eufemia.dnb.no/uilib/about-the-lib/releases/eufemia/v10-info ### breaking * v10 ([be59f35](be59f35)) * remove web components and vue support (#1946) ([1d15c93](1d15c93)), closes [#1946](#1946) * re-define Media Query Breakpoints and layout width (#1373) ([db2c963](db2c963)), closes [#1373](#1373) ### 🐛 Bug Fixes * **Anchor:** comments Anchor's inner_ref usage ([#1919](#1919)) ([f97a8b9](f97a8b9)) * **Autocomplete:** pass status props to SubmitButton ([#2004](#2004)) ([59d64b8](59d64b8)) * **Badge:** enhance semantic / accessibility and inherit skeleton from provider ([#1967](#1967)) ([f74b8e3](f74b8e3)) * **Button:** remove left and right padding of tertiary button ([0984910](0984910)) * **Button:** support rel property ([#1990](#1990)) ([1f4b5a9](1f4b5a9)) * **Dl:** ensure horizontal wrap no matter what available space ([#1965](#1965)) ([907c1b4](907c1b4)) * fix breadcumb alignment after tertiary button changes ([a6a7600](a6a7600)) * fix pagination alignment after tertiary button changes ([21a8ed9](21a8ed9)) * **InfoCard:** enhance accessibility + set max width of 60ch ([#1977](#1977)) ([88ae6f7](88ae6f7)) * remove `maintained node versions` from .browserslistrc ([#1917](#1917)) ([346d99f](346d99f)), closes [#1912](#1912) * **Timeline:** use ordered list element ([#1962](#1962)) ([dcf8fd9](dcf8fd9)) * upgrade Stylelint from v13 to v15 ([#1995](#1995)) ([c6ec59b](c6ec59b)) ### ✨ Features * **Anchor:** deprecate property target_blank_title ([#1882](#1882)) ([ee893bb](ee893bb)) * build pure component css packages (without deps) ([#1928](#1928)) ([8dbd3a4](8dbd3a4)) * **build:** replace node-sass with dart-sass ([#1934](#1934)) ([697f2be](697f2be)) * **Checkbox:** deprecate default_state property ([#1863](#1863)) ([618e7a6](618e7a6)) * deprecate StepIndicator v1 ([#1840](#1840)) ([0cbfb13](0cbfb13)) * **DrawerList:** remove use_drawer_on_mobile & enable_closest_observer ([#1879](#1879)) ([c3c50cd](c3c50cd)) * **Dropdown:** remove deprecated selected_item property ([#1870](#1870)) ([4731c0f](4731c0f)) * **Element:** deprecate css, class, inner_ref, skeleton_method ([#1859](#1859)) ([d66642c](d66642c)) * **FormRow:** remove indent feature ([#1975](#1975)) ([07418bd](07418bd)) * **FormStatus:** remove deprecated status property ([#1914](#1914)) ([c28ed21](c28ed21)) * **GlobalStatus:** deprecate AddStatus & Set ([#1891](#1891)) ([09fb3d9](09fb3d9)) * **H:** deprecate is and style_type properties ([#1856](#1856)) ([6208d9a](6208d9a)) * **Helpers:** deprecate .dnb-sr-only--inline & .dnb-not-sr-only ([#1865](#1865)) ([8d73d6f](8d73d6f)) * include all type definitions in repo ([#1996](#1996)) ([fe9347d](fe9347d)) * **InputMasked:** ATTENTION! make allowLeadingZeroes default to true ([#1126](#1126)) ([4c738d6](4c738d6)) * **Modal, Dialog, Drawer:** remove closeButtonAttributes ([#1926](#1926)) ([5d1a775](5d1a775)) * **Modal:** remove deprecated mode prop ([#1993](#1993)) ([2204d49](2204d49)) * **Modal:** remove deprecated trigger_ props ([#1918](#1918)) ([88790b9](88790b9)) * new browserslist config for es6 builds ([#1833](#1833)) ([1341695](1341695)) * **Number:** Removes component ([#1924](#1924)) ([024373b](024373b)) * **P:** deprecate style_type property ([#1855](#1855)) ([febe82a](febe82a)) * **P:** remove deprecated class dnb-p--ingress ([#1872](#1872)) ([bc9799c](bc9799c)) * remove support for internet explorer ([#1807](#1807)) ([a175f6d](a175f6d)) * replace visual test driver to jest-image-snapshot and Firefox (Playwright) ([#1945](#1945)) ([f95d547](f95d547)), closes [/github.com/puppeteer/puppeteer/issues/7514#issuecomment-1005917527](https://github.com/dnbexperience//github.com/puppeteer/puppeteer/issues/7514/issues/issuecomment-1005917527) [/github.com/dnbexperience/eufemia/blob/88279d1e6903497fce40d6c4322dd9b7c7b9ac3b/packages/dnb-eufemia/src/core/jest/jestSetupScreenshots.js#L39](https://github.com/dnbexperience//github.com/dnbexperience/eufemia/blob/88279d1e6903497fce40d6c4322dd9b7c7b9ac3b/packages/dnb-eufemia/src/core/jest/jestSetupScreenshots.js/issues/L39) * **ScrollView:** add interactive=auto to observe the content ([#1984](#1984)) ([6bca0fe](6bca0fe)) * **Section:** deprecate style_type signal-orange ([#1886](#1886)) ([97e0d40](97e0d40)) * **SkipContent:** add new component to skip large contents when using tab key ([#1981](#1981)) ([9607418](9607418)) * **Slider:** deprecate use_scrollwheel ([#1889](#1889)) ([be4c5ed](be4c5ed)) * **Slider:** remove deprecated onInit prop ([#1909](#1909)) ([0129d99](0129d99)) * **Slider:** remove dnb-range styling ([#1890](#1890)) ([7242797](7242797)) * **Space:** add conditional reset class: `dnb-space__reset` ([#1961](#1961)) ([e310b65](e310b65)) * **SpacingUtils:** deprecate createStyleObject ([#1892](#1892)) ([4c804da](4c804da)) * **Switch:** deprecate default_state property ([#1864](#1864)) ([de21dff](de21dff)) * **Table:** deprecate sticky_offset ([#1883](#1883)) ([d76de14](d76de14)) * **Tags:** removed deprecated comments ([#1857](#1857)) ([1ad76b2](1ad76b2)) * **Timeline:** deprecate name and date props ([#1884](#1884)) ([dfb2284](dfb2284)) * **Typography:** removed deprecated comments ([#1858](#1858)) ([7a5336f](7a5336f)) ### 📝 Documentation * add change log about v10 ([811b07b](811b07b)) * add info about the tertiary button "visual" breaking change ([a4e0032](a4e0032)) * **Dropdown:** remove selected_key in events on_change & on_select ([#2001](#2001)) ([9e45682](9e45682)) * Move Modal to Dialog/Drawer conversion docs to v10 migration ([#1921](#1921)) ([492ed9b](492ed9b)) * **ProgressIndicator:** removes props min_time and variant ([#1997](#1997)) ([86e9cd8](86e9cd8)) * refactor contribution guide getting started ([#2008](#2008)) ([e9d5e27](e9d5e27)) * remove outdated info ([#1940](#1940)) ([99517f1](99517f1)) * **Spacing:** minor improvement to space example ([#1992](#1992)) ([80c5f1a](80c5f1a)) * **Table:** add info about the needed CSS class in v10 ([#1923](#1923)) ([336de44](336de44)) * update docs about CSS formatting and styling ([#1964](#1964)) ([04a0013](04a0013)) * update v10 change log ([#1983](#1983)) ([1f53c26](1f53c26)) * update v10-info ([#1998](#1998)) ([c2c8c5c](c2c8c5c))
## [10.0.0-beta.1](v9.47.1...v10.0.0-beta.1) (2023-02-23) ### ⚠ BREAKING CHANGES * **Modal:** - Modal: Remove deprecated `mode` prop – it will default to `custom` mode. Use rather the `Dialog` or the `Drawer` component. * Remove support for Web Components and Vue * re-define Media Query Breakpoints and layout width * Read the docs about migration: https://eufemia.dnb.no/uilib/about-the-lib/releases/eufemia/v10-info * remove web components and vue support (#1946) ([baa4ca3](baa4ca3)), closes [#1946](#1946) * re-define Media Query Breakpoints and layout width (#1373) ([73d1b77](73d1b77)), closes [#1373](#1373) * v10 ([514becd](514becd)) ### 🐛 Bug Fixes * **Anchor:** comments Anchor's inner_ref usage ([#1919](#1919)) ([7653316](7653316)) * **Autocomplete:** pass status props to SubmitButton ([#2004](#2004)) ([fb89114](fb89114)) * **Badge:** enhance semantic / accessibility and inherit skeleton from provider ([#1967](#1967)) ([5a870a7](5a870a7)) * **Button:** remove left and right padding of tertiary button ([5919c79](5919c79)) * **Button:** support rel property ([#1990](#1990)) ([ad029f2](ad029f2)) * **Dl:** ensure horizontal wrap no matter what available space ([#1965](#1965)) ([ab15893](ab15893)) * fix breadcumb alignment after tertiary button changes ([2989af1](2989af1)) * fix pagination alignment after tertiary button changes ([ce6e5ea](ce6e5ea)) * **InfoCard:** enhance accessibility + set max width of 60ch ([#1977](#1977)) ([5a4f344](5a4f344)) * remove `maintained node versions` from .browserslistrc ([#1917](#1917)) ([9cb43c4](9cb43c4)), closes [#1912](#1912) * **Timeline:** use ordered list element ([#1962](#1962)) ([2b77b8e](2b77b8e)) * upgrade Stylelint from v13 to v15 ([#1995](#1995)) ([21a1cdb](21a1cdb)) ### ✨ Features * **Anchor:** deprecate property target_blank_title ([#1882](#1882)) ([8c6448d](8c6448d)) * build pure component css packages (without deps) ([#1928](#1928)) ([5a7e111](5a7e111)) * **build:** replace node-sass with dart-sass ([#1934](#1934)) ([ba3fed2](ba3fed2)) * **Checkbox:** deprecate default_state property ([#1863](#1863)) ([e5fb21e](e5fb21e)) * deprecate StepIndicator v1 ([#1840](#1840)) ([c0d9518](c0d9518)) * **DrawerList:** remove use_drawer_on_mobile & enable_closest_observer ([#1879](#1879)) ([e56c925](e56c925)) * **Dropdown:** remove deprecated selected_item property ([#1870](#1870)) ([5321b3a](5321b3a)) * **Element:** deprecate css, class, inner_ref, skeleton_method ([#1859](#1859)) ([7b9554d](7b9554d)) * **FormRow:** remove indent feature ([#1975](#1975)) ([5c58e39](5c58e39)) * **FormStatus:** remove deprecated status property ([#1914](#1914)) ([3c867b5](3c867b5)) * **GlobalStatus:** deprecate AddStatus & Set ([#1891](#1891)) ([bf382fd](bf382fd)) * **H:** deprecate is and style_type properties ([#1856](#1856)) ([c9fb5a6](c9fb5a6)) * **Helpers:** deprecate .dnb-sr-only--inline & .dnb-not-sr-only ([#1865](#1865)) ([d84a49f](d84a49f)) * include all type definitions in repo ([#1996](#1996)) ([3a93c5a](3a93c5a)) * **InputMasked:** ATTENTION! make allowLeadingZeroes default to true ([#1126](#1126)) ([bb2edca](bb2edca)) * **Modal, Dialog, Drawer:** remove closeButtonAttributes ([#1926](#1926)) ([82cd99d](82cd99d)) * **Modal:** remove deprecated mode prop ([#1993](#1993)) ([86c8adc](86c8adc)) * **Modal:** remove deprecated trigger_ props ([#1918](#1918)) ([2eced1b](2eced1b)) * new browserslist config for es6 builds ([#1833](#1833)) ([ab57b84](ab57b84)) * **Number:** Removes component ([#1924](#1924)) ([aeaadc0](aeaadc0)) * **P:** deprecate style_type property ([#1855](#1855)) ([74bc0ea](74bc0ea)) * **P:** remove deprecated class dnb-p--ingress ([#1872](#1872)) ([04e4632](04e4632)) * remove support for internet explorer ([#1807](#1807)) ([fbfd636](fbfd636)) * replace visual test driver to jest-image-snapshot and Firefox (Playwright) ([#1945](#1945)) ([fcc9348](fcc9348)), closes [/github.com/puppeteer/puppeteer/issues/7514#issuecomment-1005917527](https://github.com/dnbexperience//github.com/puppeteer/puppeteer/issues/7514/issues/issuecomment-1005917527) [/github.com/dnbexperience/eufemia/blob/88279d1e6903497fce40d6c4322dd9b7c7b9ac3b/packages/dnb-eufemia/src/core/jest/jestSetupScreenshots.js#L39](https://github.com/dnbexperience//github.com/dnbexperience/eufemia/blob/88279d1e6903497fce40d6c4322dd9b7c7b9ac3b/packages/dnb-eufemia/src/core/jest/jestSetupScreenshots.js/issues/L39) * **ScrollView:** add interactive=auto to observe the content ([#1984](#1984)) ([988390c](988390c)) * **Section:** deprecate style_type signal-orange ([#1886](#1886)) ([661d976](661d976)) * **SkipContent:** add new component to skip large contents when using tab key ([#1981](#1981)) ([c44ef28](c44ef28)) * **Slider:** deprecate use_scrollwheel ([#1889](#1889)) ([639df46](639df46)) * **Slider:** remove deprecated onInit prop ([#1909](#1909)) ([0595a53](0595a53)) * **Slider:** remove dnb-range styling ([#1890](#1890)) ([1d2693c](1d2693c)) * **Space:** add conditional reset class: `dnb-space__reset` ([#1961](#1961)) ([a79bb2a](a79bb2a)) * **SpacingUtils:** deprecate createStyleObject ([#1892](#1892)) ([cadf378](cadf378)) * **Switch:** deprecate default_state property ([#1864](#1864)) ([da2c568](da2c568)) * **Table:** deprecate sticky_offset ([#1883](#1883)) ([5a242a1](5a242a1)) * **Tags:** removed deprecated comments ([#1857](#1857)) ([9af5268](9af5268)) * **Timeline:** deprecate name and date props ([#1884](#1884)) ([a95db13](a95db13)) * **Typography:** removed deprecated comments ([#1858](#1858)) ([1fd2b48](1fd2b48)) ### 📝 Documentation * add change log about v10 ([8cbf228](8cbf228)) * add info about the tertiary button "visual" breaking change ([4df8d93](4df8d93)) * **Dropdown:** remove selected_key in events on_change & on_select ([#2001](#2001)) ([c540619](c540619)) * Move Modal to Dialog/Drawer conversion docs to v10 migration ([#1921](#1921)) ([cb43cf4](cb43cf4)) * **NumberFormat:** fix info docs ([#2009](#2009)) ([30a529a](30a529a)) * **ProgressIndicator:** removes props min_time and variant ([#1997](#1997)) ([f734a1a](f734a1a)) * refactor contribution guide getting started ([#2008](#2008)) ([94d5f43](94d5f43)) * remove outdated info ([#1940](#1940)) ([eb93445](eb93445)) * **Spacing:** minor improvement to space example ([#1992](#1992)) ([5b71585](5b71585)) * **Table:** add info about the needed CSS class in v10 ([#1923](#1923)) ([c724175](c724175)) * update docs about CSS formatting and styling ([#1964](#1964)) ([ab2dd40](ab2dd40)) * update v10 change log ([#1983](#1983)) ([bd41665](bd41665)) * update v10-info ([#1998](#1998)) ([9ae40f1](9ae40f1))
🎉 This PR is included in version 10.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [9.47.2](v9.47.1...v9.47.2) (2023-03-16) ### Bug Fixes * **Autocomplete:** pass status props to SubmitButton ([#2004](#2004)) ([fb89114](fb89114)) * **Button:** support rel property ([#1990](#1990)) ([ad029f2](ad029f2)) * remove FormRow context support from components not using FormRow ([#2103](#2103)) ([3a39134](3a39134))
🎉 This PR is included in version 9.47.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sort of a continuation of #1817
This PR is adding documentation and "TypeScript support" for the
rel
property.Here's an example of when consumers using TypeScript, tries to use the Button component with the
rel
property as of today(pre this PR):