fix(TableContainer): ensure bottom border on all tables #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tujoworker
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit de69f6d:
|
✅ DNB Eufemia Portal deploy preview ready
|
NancyBolstad
approved these changes
Feb 3, 2023
packages/dnb-eufemia/src/components/table/__tests__/__snapshots__/Table.test.tsx.snap
Show resolved
Hide resolved
NancyBolstad
reviewed
Feb 3, 2023
packages/dnb-eufemia/src/components/table/__tests__/__snapshots__/Table.test.tsx.snap
Show resolved
Hide resolved
tujoworker
pushed a commit
that referenced
this pull request
Feb 5, 2023
# [9.47.0](v9.46.2...v9.47.0) (2023-02-05) ### Bug Fixes * **TableContainer:** enhance handling of empty head and foot area ([#1970](#1970)) ([762c667](762c667)) * **TableContainer:** ensure bottom border on all tables ([#1969](#1969)) ([4583ba8](4583ba8)) ### Features * **Table:** add support for row scope only header ([#1971](#1971)) ([aff2e40](aff2e40))
|
🎉 This PR is included in version 9.47.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
joakbjerk
pushed a commit
that referenced
this pull request
Mar 27, 2023
* fix(TableContainer): ensure bottom border on all tables * Update snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue introduced in #1956 where the first table in a container, has no bottom border.