Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TableContainer): enhance handling of empty head and foot area #1970

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

tujoworker
Copy link
Member

@tujoworker tujoworker commented Feb 2, 2023

This PR is based on #1969

It corrects the height of the foot/head area when they are empty. Now they even do not need to exists.

@tujoworker tujoworker changed the base branch from main to fix/table-container-bottom-border February 2, 2023 20:33
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 2, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a977924:

Sandbox Source
eufemia-starter Configuration

@gatsby-cloud
Copy link

gatsby-cloud bot commented Feb 2, 2023

✅ DNB Eufemia Portal deploy preview ready

@tujoworker tujoworker requested a review from a team February 3, 2023 07:45
Copy link

@NancyBolstad NancyBolstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@tujoworker tujoworker force-pushed the fix/table-container-empty branch from adbcfc0 to 3470a85 Compare February 3, 2023 09:37
Base automatically changed from fix/table-container-bottom-border to main February 3, 2023 09:43
@tujoworker tujoworker force-pushed the fix/table-container-empty branch from 3470a85 to a977924 Compare February 3, 2023 09:45
@tujoworker tujoworker merged commit 762c667 into main Feb 3, 2023
@tujoworker tujoworker deleted the fix/table-container-empty branch February 3, 2023 10:34
tujoworker pushed a commit that referenced this pull request Feb 5, 2023
# [9.47.0](v9.46.2...v9.47.0) (2023-02-05)

### Bug Fixes

* **TableContainer:** enhance handling of empty head and foot area ([#1970](#1970)) ([762c667](762c667))
* **TableContainer:** ensure bottom border on all tables ([#1969](#1969)) ([4583ba8](4583ba8))

### Features

* **Table:** add support for row scope only header ([#1971](#1971)) ([aff2e40](aff2e40))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 9.47.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants