feat(Accordion): allow multiple accordions inside a group to be expanded at the same time #3726
Conversation
joakbjerk
commented
Jun 19, 2024
•
joakbjerk
commented
- Add expansion behavior prop instead
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joakbjerk
requested review from
tujoworker,
langz and
AadneRo
and removed request for
tujoworker
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| context.flush_remembered_state, | ||
| context.expanded_id, | ||
| props.expanded, | ||
| props.id, |
There was a problem hiding this comment.
| props.id, | |
| id, |
Is there a reason we don't use the deconstructed props like this?
There was a problem hiding this comment.
Nope 😄 We should propably clean that up in a seperate pr, since there seem to be a lot of those occurances
|
|
||
| it('should allow all accordions inside a group to be expanded at the same time', async () => { | ||
| render( | ||
| <Accordion.Group allowAllExpanded> |
There was a problem hiding this comment.
I think the prop name allowAllExpanded is misleading. What if we rather add a expandBehavior prop? That defaults to "single" or something. But can be changed to "multi".
There was a problem hiding this comment.
Good idea, that seems more readable 👍
## [10.38.0](v10.37.0...v10.38.0) (2024-06-26) ### 🐛 Bug Fixes * **Accordion:** add missing bottom border on hover ([#3723](#3723)) ([41fb027](41fb027)) ### 📝 Documentation * **Button:** add 'small' button size as supported ([#3735](#3735)) ([686cb90](686cb90)) ### ✨ Features * **Accordion:** allow multiple accordions inside a group to be expanded at the same time ([#3726](#3726)) ([68d3b0b](68d3b0b)) * **Card:** add support for nesting a Section with breakout until edge of card ([#3728](#3728)) ([97e92c2](97e92c2)) * **forms:** add property compensateForGap to Visibility ([#3733](#3733)) ([3094b18](3094b18)), closes [#3732](#3732) * **forms:** add support for nested `Section` and `ArraySelection` fields ([#3734](#3734)) ([d4b3bb4](d4b3bb4)), closes [#3733](#3733) * **HeightAnimation:** add property `compensateForGap` ([#3732](#3732)) ([b0c4199](b0c4199))
|
🎉 This PR is included in version 10.38.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
