Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Accordion): add missing bottom border on hover #3723

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

joakbjerk
Copy link
Contributor

closes #3641

Before:
Screenshot 2024-06-19 at 08 36 35

After:
Screenshot 2024-06-19 at 08 36 17

@joakbjerk joakbjerk requested a review from tujoworker June 19, 2024 06:40
Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 10:32am

@joakbjerk joakbjerk changed the title fix Accordion hover border inset fix(Accordion): add missing bottom border on hover Jun 19, 2024
Copy link

codesandbox-ci bot commented Jun 19, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@joakbjerk joakbjerk requested review from AadneRo and langz June 19, 2024 08:36
@joakbjerk joakbjerk force-pushed the fix/accordion-hover-border-inset branch from 9f4de19 to 30b97e4 Compare June 19, 2024 10:09
Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@joakbjerk joakbjerk merged commit 41fb027 into main Jun 21, 2024
10 checks passed
@joakbjerk joakbjerk deleted the fix/accordion-hover-border-inset branch June 21, 2024 10:29
tujoworker pushed a commit that referenced this pull request Jun 26, 2024
## [10.38.0](v10.37.0...v10.38.0) (2024-06-26)

### 🐛 Bug Fixes

* **Accordion:** add missing bottom border on hover ([#3723](#3723)) ([41fb027](41fb027))

### 📝 Documentation

* **Button:** add 'small' button size as supported ([#3735](#3735)) ([686cb90](686cb90))

### ✨ Features

* **Accordion:** allow multiple accordions inside a group to be expanded at the same time ([#3726](#3726)) ([68d3b0b](68d3b0b))
* **Card:** add support for nesting a Section with breakout until edge of card ([#3728](#3728)) ([97e92c2](97e92c2))
* **forms:** add property compensateForGap to Visibility ([#3733](#3733)) ([3094b18](3094b18)), closes [#3732](#3732)
* **forms:** add support for nested `Section` and `ArraySelection` fields ([#3734](#3734)) ([d4b3bb4](d4b3bb4)), closes [#3733](#3733)
* **HeightAnimation:** add property `compensateForGap` ([#3732](#3732)) ([b0c4199](b0c4199))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

bug(Accordion): bottom focus outline hidden behind other Accordions on hover
3 participants