Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Forms): enhance cleanup routine of fields #3885

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

tujoworker
Copy link
Member

@tujoworker tujoworker commented Sep 1, 2024

I noticed a couple of issues due to the fact that we mount/unmount parts without a effect dependency. It was about getting the right content in fields that where removed/added dynamically inside iterate while working on this PR #3877.

But I think we should rather pull out these changed and submit by its own PR. I have not checked any examples/demos. But would love if someone checks it for me, especially the error handling in field compositions (FieldBlock with nested fields).

But in overall, it "should not" have a negative effect on existing implementations.

Copy link

vercel bot commented Sep 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 2, 2024 8:20pm

Copy link

codesandbox-ci bot commented Sep 1, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@tujoworker tujoworker force-pushed the fix/mount-unmount-routine branch from 4314bce to cbf63fc Compare September 2, 2024 20:06
@tujoworker tujoworker merged commit 388e0b2 into main Sep 4, 2024
10 checks passed
@tujoworker tujoworker deleted the fix/mount-unmount-routine branch September 4, 2024 05:37
tujoworker pushed a commit that referenced this pull request Sep 10, 2024
## [10.47.0](v10.46.0...v10.47.0) (2024-09-10)

### 📝 Documentation

* add component translations table to properties docs ([#3902](#3902)) ([66dd12e](66dd12e))
* **useTheme:** updates docs to match TS type definitions ([#3901](#3901)) ([52aaab3](52aaab3))

### ✨ Features

* **Button:** rewise documented `title` prop with aria-label documentation ([#3863](#3863)) ([ea444c0](ea444c0))
* **CopyOnClick:** adds copyContent prop ([e5a91b6](e5a91b6))
* **countries:** Added missing countries from ISO 3166 [#3894](#3894) ([2992084](2992084))
* **countries:** Added missing countries from ISO 3166 [#3894](#3894) ([#3899](#3899)) ([ada0e92](ada0e92))
* **Forms:** extend validations in `Field.NationalIdentityNumber` ([#3888](#3888)) ([50cc26b](50cc26b))
* **Forms:** make it possible to reuse and extend internal validators ([#3908](#3908)) ([7c97bf5](7c97bf5))
* **Forms:** provide `connectWithPath` in the validator and onBlurValidator to get values from other fields/paths ([#3895](#3895)) ([f4cf06f](f4cf06f))
* **Value.Date:** adds numeric variant ([#3907](#3907)) ([b03e199](b03e199))

### 🐛 Bug Fixes

* **Accordion:** deprecate (rename) expandBehaviour in favor of expandBehavior ([#3905](#3905)) ([76143b0](76143b0))
* **Breakpoint:** ensure matching breakpoint ranges in mixins with docs & hooks ([#3896](#3896)) ([260fcaf](260fcaf))
* **Flex:** enhance handling of React fragments ([#3892](#3892)) ([156c805](156c805))
* **Forms:** enhance cleanup routine of fields ([#3885](#3885)) ([388e0b2](388e0b2)), closes [#3877](#3877)
* **Forms:** ensure label supports HTML formatting ([#3911](#3911)) ([227569c](227569c))
* **Forms:** ensure labels do update when they change (async fields) ([#3910](#3910)) ([bc40449](bc40449))
* **Forms:** warn on value prop usage on fields inside iterate with itemPath ([#3886](#3886)) ([116820d](116820d)), closes [#3877](#3877) [#3882](#3882)
* **LabelDescription:** nothing was returned ([#3898](#3898)) ([3452855](3452855))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 10.47.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants