Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Country list is not complete per ISO 3166-1 alpha-2 #3894

Closed
andlbrei opened this issue Sep 4, 2024 · 0 comments · Fixed by #3899
Closed

Country list is not complete per ISO 3166-1 alpha-2 #3894

andlbrei opened this issue Sep 4, 2024 · 0 comments · Fixed by #3899
Assignees
@andlbrei

Comments

@andlbrei
Copy link
Contributor

andlbrei commented Sep 4, 2024

🐛 Bug Report

This isn't really a bug I guess, but I think the country list should be based on a standard list of countries, and not a phone country code list.
Our team requires compliance with https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2 and cannot use Eufemia for the country list unless it is updated.
One issue with this approach is that we need to do some research to figure out which phone country code a country has for the countries that are in ISO 3166 alpha-2 but not in the phone country code list. Most likely these countries are autonomous regions of other countries.

I will make an MR with a ISO 3166-1 alpha-2 compliant list of countries.
@andlbrei andlbrei self-assigned this Sep 4, 2024
andlbrei pushed a commit that referenced this issue Sep 5, 2024
feat(countries): Added missing countries from ISO 3166 #3894
e6b7ed2
andlbrei pushed a commit that referenced this issue Sep 5, 2024
feat(countries): Added missing countries from ISO 3166 #3894
ab7be3a
@andlbrei andlbrei linked a pull request Sep 5, 2024 that will close this issue
feat(countries): Added missing countries from ISO 3166 #3894 #3899
Merged
andlbrei pushed a commit that referenced this issue Sep 5, 2024
feat(countries): Added missing countries from ISO 3166 #3894
2992084
andlbrei added a commit that referenced this issue Sep 5, 2024
@andlbrei
feat(countries): Added missing countries from ISO 3166 #3894 (#3899)
ada0e92 
The reasoning for adding these countries is that they are required for
compliance reasons for application in some of DNBs solutions.

The country list in Eufemia serves two purposes in letting users select
countries and letting users select the dialing code for a country.
The country codes missing from ISO 3166 are mostly for external
territories of other states.
The dialing code for some of them are certain, and are contained in the
wikipedia page the country list was based on earlier.
For others the dialing code is not certain, and most likely they do not
have a dialing code. These countries are mostly research bases, or
otherwise not permanently inhabited.

The likelyhood of any of these countries actually being used is probably
very small.

In the event that someone should want to use a number from one of the
uncertain dialing codes, they will most likely identify that the dialing
code is wrong. As far as I can tell each of these countries belong to a
group of islands or a territory that they share a dialing code with, and
we can probably assume that the users of these dialing codes knows which
other country to look for in the list.

Added the following countries:
- AX	Åland Islands - Shared dialing code with Finland
- BV Bouvet Island - Most likely no dialing code, uses the dialing code
of Norway
- TF French Southern Territories - Most likely no dialing code, uses the
dialing code of Mayoette and Reunion
- HM Heard Island and McDonald Islands - Same dialing code as Australian
External Territories
- MQ	Martinique
- NF Norfolk Island - Same dialing code as Australian External
Territories
- GS South Georgia and the South Sandwich Islands - Same dialing code as
Falkland Islands
- UM United States Minor Outlying Islands - Most likely no dialing code,
uses the dialing code of USA
- BQ	Bonaire, Sint Eustatius and Saba
tujoworker pushed a commit that referenced this issue Sep 10, 2024
@semantic-release-bot
chore(release): 10.47.0 [skip ci]
121ced0 
## [10.47.0](v10.46.0...v10.47.0) (2024-09-10)

### 📝 Documentation

* add component translations table to properties docs ([#3902](#3902)) ([66dd12e](66dd12e))
* **useTheme:** updates docs to match TS type definitions ([#3901](#3901)) ([52aaab3](52aaab3))

### ✨ Features

* **Button:** rewise documented `title` prop with aria-label documentation ([#3863](#3863)) ([ea444c0](ea444c0))
* **CopyOnClick:** adds copyContent prop ([e5a91b6](e5a91b6))
* **countries:** Added missing countries from ISO 3166 [#3894](#3894) ([2992084](2992084))
* **countries:** Added missing countries from ISO 3166 [#3894](#3894) ([#3899](#3899)) ([ada0e92](ada0e92))
* **Forms:** extend validations in `Field.NationalIdentityNumber` ([#3888](#3888)) ([50cc26b](50cc26b))
* **Forms:** make it possible to reuse and extend internal validators ([#3908](#3908)) ([7c97bf5](7c97bf5))
* **Forms:** provide `connectWithPath` in the validator and onBlurValidator to get values from other fields/paths ([#3895](#3895)) ([f4cf06f](f4cf06f))
* **Value.Date:** adds numeric variant ([#3907](#3907)) ([b03e199](b03e199))

### 🐛 Bug Fixes

* **Accordion:** deprecate (rename) expandBehaviour in favor of expandBehavior ([#3905](#3905)) ([76143b0](76143b0))
* **Breakpoint:** ensure matching breakpoint ranges in mixins with docs & hooks ([#3896](#3896)) ([260fcaf](260fcaf))
* **Flex:** enhance handling of React fragments ([#3892](#3892)) ([156c805](156c805))
* **Forms:** enhance cleanup routine of fields ([#3885](#3885)) ([388e0b2](388e0b2)), closes [#3877](#3877)
* **Forms:** ensure label supports HTML formatting ([#3911](#3911)) ([227569c](227569c))
* **Forms:** ensure labels do update when they change (async fields) ([#3910](#3910)) ([bc40449](bc40449))
* **Forms:** warn on value prop usage on fields inside iterate with itemPath ([#3886](#3886)) ([116820d](116820d)), closes [#3877](#3877) [#3882](#3882)
* **LabelDescription:** nothing was returned ([#3898](#3898)) ([3452855](3452855))
@andlbrei andlbrei mentioned this issue Sep 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andlbrei andlbrei

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(countries): Added missing countries from ISO 3166 #3894 dnbexperience/eufemia
1 participant
@andlbrei