fix(Forms): warn on value prop usage on fields inside iterate with itemPath #3886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tujoworker
added a commit
that referenced
this pull request
Sep 1, 2024
tujoworker
added a commit
that referenced
this pull request
Sep 1, 2024
…st item as initially open Close items when PushContainer opens Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/demos.mdx Co-authored-by: Anders <anderslangseth@gmail.com> Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/Examples.tsx Co-authored-by: Anders <anderslangseth@gmail.com> Ensure correct error message and avoid cancel click when item has error Revert useExternalValue path change Remove prioritizeDataContextInjection in favor of better solution Revert support for value and defaultValue inside iterate Ensure auto-closing mechanism works consistently – remove useUnmountEffect because of the lack of possible changing deps Ensure correct mount/unmount by using correct deps handling Rename `initial-open` to `initiallyOpen` Move value warning to its own PR #3886
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
langz
approved these changes
Sep 1, 2024
langz
reviewed
Sep 2, 2024
packages/dnb-eufemia/src/extensions/forms/hooks/useFieldProps.ts
Outdated
Show resolved
Hide resolved
langz
reviewed
Sep 2, 2024
packages/dnb-eufemia/src/extensions/forms/hooks/useFieldProps.ts
Outdated
Show resolved
Hide resolved
langz
reviewed
Sep 2, 2024
packages/dnb-eufemia/src/extensions/forms/Iterate/Array/__tests__/Array.test.tsx
Outdated
Show resolved
Hide resolved
…s__/Array.test.tsx
langz
reviewed
Sep 2, 2024
packages/dnb-eufemia/src/extensions/forms/Iterate/Array/__tests__/Array.test.tsx
Outdated
Show resolved
Hide resolved
…s__/Array.test.tsx
tujoworker
added a commit
that referenced
this pull request
Sep 7, 2024
…lbarWhen` property to Iterate.Array – show first item as initially open Close items when PushContainer opens Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/demos.mdx Co-authored-by: Anders <anderslangseth@gmail.com> Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/Examples.tsx Co-authored-by: Anders <anderslangseth@gmail.com> Ensure correct error message and avoid cancel click when item has error Revert useExternalValue path change Remove prioritizeDataContextInjection in favor of better solution Revert support for value and defaultValue inside iterate Ensure auto-closing mechanism works consistently – remove useUnmountEffect because of the lack of possible changing deps Ensure correct mount/unmount by using correct deps handling Rename `initial-open` to `initiallyOpen` Move value warning to its own PR #3886
tujoworker
added a commit
that referenced
this pull request
Sep 7, 2024
…lbarWhen` property to Iterate.Array – show first item as initially open Close items when PushContainer opens Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/demos.mdx Co-authored-by: Anders <anderslangseth@gmail.com> Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/Examples.tsx Co-authored-by: Anders <anderslangseth@gmail.com> Ensure correct error message and avoid cancel click when item has error Revert useExternalValue path change Remove prioritizeDataContextInjection in favor of better solution Revert support for value and defaultValue inside iterate Ensure auto-closing mechanism works consistently – remove useUnmountEffect because of the lack of possible changing deps Ensure correct mount/unmount by using correct deps handling Rename `initial-open` to `initiallyOpen` Move value warning to its own PR #3886
tujoworker
added a commit
that referenced
this pull request
Sep 7, 2024
…lbarWhen` property to Iterate.Array – show first item as initially open Close items when PushContainer opens Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/demos.mdx Co-authored-by: Anders <anderslangseth@gmail.com> Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/Examples.tsx Co-authored-by: Anders <anderslangseth@gmail.com> Ensure correct error message and avoid cancel click when item has error Revert useExternalValue path change Remove prioritizeDataContextInjection in favor of better solution Revert support for value and defaultValue inside iterate Ensure auto-closing mechanism works consistently – remove useUnmountEffect because of the lack of possible changing deps Ensure correct mount/unmount by using correct deps handling Rename `initial-open` to `initiallyOpen` Move value warning to its own PR #3886
tujoworker
added a commit
that referenced
this pull request
Sep 7, 2024
…lbarWhen` property to Iterate.Array – show first item as initially open Close items when PushContainer opens Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/demos.mdx Co-authored-by: Anders <anderslangseth@gmail.com> Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/Examples.tsx Co-authored-by: Anders <anderslangseth@gmail.com> Ensure correct error message and avoid cancel click when item has error Revert useExternalValue path change Remove prioritizeDataContextInjection in favor of better solution Revert support for value and defaultValue inside iterate Ensure auto-closing mechanism works consistently – remove useUnmountEffect because of the lack of possible changing deps Ensure correct mount/unmount by using correct deps handling Rename `initial-open` to `initiallyOpen` Move value warning to its own PR #3886
tujoworker
added a commit
that referenced
this pull request
Sep 8, 2024
…lbarWhen` property to Iterate.Array – show first item as initially open Close items when PushContainer opens Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/demos.mdx Co-authored-by: Anders <anderslangseth@gmail.com> Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/Examples.tsx Co-authored-by: Anders <anderslangseth@gmail.com> Ensure correct error message and avoid cancel click when item has error Revert useExternalValue path change Remove prioritizeDataContextInjection in favor of better solution Revert support for value and defaultValue inside iterate Ensure auto-closing mechanism works consistently – remove useUnmountEffect because of the lack of possible changing deps Ensure correct mount/unmount by using correct deps handling Rename `initial-open` to `initiallyOpen` Move value warning to its own PR #3886
tujoworker
added a commit
that referenced
this pull request
Sep 8, 2024
…lbarWhen` property to Iterate.Array – show first item as initially open Close items when PushContainer opens Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/demos.mdx Co-authored-by: Anders <anderslangseth@gmail.com> Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/Examples.tsx Co-authored-by: Anders <anderslangseth@gmail.com> Ensure correct error message and avoid cancel click when item has error Revert useExternalValue path change Remove prioritizeDataContextInjection in favor of better solution Revert support for value and defaultValue inside iterate Ensure auto-closing mechanism works consistently – remove useUnmountEffect because of the lack of possible changing deps Ensure correct mount/unmount by using correct deps handling Rename `initial-open` to `initiallyOpen` Move value warning to its own PR #3886
tujoworker
added a commit
that referenced
this pull request
Sep 9, 2024
…lbarWhen` property to Iterate.Array – show first item as initially open Close items when PushContainer opens Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/demos.mdx Co-authored-by: Anders <anderslangseth@gmail.com> Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/Examples.tsx Co-authored-by: Anders <anderslangseth@gmail.com> Ensure correct error message and avoid cancel click when item has error Revert useExternalValue path change Remove prioritizeDataContextInjection in favor of better solution Revert support for value and defaultValue inside iterate Ensure auto-closing mechanism works consistently – remove useUnmountEffect because of the lack of possible changing deps Ensure correct mount/unmount by using correct deps handling Rename `initial-open` to `initiallyOpen` Move value warning to its own PR #3886
tujoworker
added a commit
that referenced
this pull request
Sep 9, 2024
…lbarWhen` property to Iterate.Array – show first item as initially open Close items when PushContainer opens Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/demos.mdx Co-authored-by: Anders <anderslangseth@gmail.com> Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/Examples.tsx Co-authored-by: Anders <anderslangseth@gmail.com> Ensure correct error message and avoid cancel click when item has error Revert useExternalValue path change Remove prioritizeDataContextInjection in favor of better solution Revert support for value and defaultValue inside iterate Ensure auto-closing mechanism works consistently – remove useUnmountEffect because of the lack of possible changing deps Ensure correct mount/unmount by using correct deps handling Rename `initial-open` to `initiallyOpen` Move value warning to its own PR #3886
tujoworker
added a commit
that referenced
this pull request
Sep 9, 2024
…lbarWhen` property to Iterate.Array – show first item as initially open Close items when PushContainer opens Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/demos.mdx Co-authored-by: Anders <anderslangseth@gmail.com> Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/Examples.tsx Co-authored-by: Anders <anderslangseth@gmail.com> Ensure correct error message and avoid cancel click when item has error Revert useExternalValue path change Remove prioritizeDataContextInjection in favor of better solution Revert support for value and defaultValue inside iterate Ensure auto-closing mechanism works consistently – remove useUnmountEffect because of the lack of possible changing deps Ensure correct mount/unmount by using correct deps handling Rename `initial-open` to `initiallyOpen` Move value warning to its own PR #3886
tujoworker
added a commit
that referenced
this pull request
Sep 9, 2024
…lbarWhen` property to Iterate.Array – show first item as initially open Close items when PushContainer opens Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/demos.mdx Co-authored-by: Anders <anderslangseth@gmail.com> Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/Examples.tsx Co-authored-by: Anders <anderslangseth@gmail.com> Ensure correct error message and avoid cancel click when item has error Revert useExternalValue path change Remove prioritizeDataContextInjection in favor of better solution Revert support for value and defaultValue inside iterate Ensure auto-closing mechanism works consistently – remove useUnmountEffect because of the lack of possible changing deps Ensure correct mount/unmount by using correct deps handling Rename `initial-open` to `initiallyOpen` Move value warning to its own PR #3886
tujoworker
added a commit
that referenced
this pull request
Sep 10, 2024
…lbarWhen` property to Iterate.Array – show first item as initially open Close items when PushContainer opens Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/demos.mdx Co-authored-by: Anders <anderslangseth@gmail.com> Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/Examples.tsx Co-authored-by: Anders <anderslangseth@gmail.com> Ensure correct error message and avoid cancel click when item has error Revert useExternalValue path change Remove prioritizeDataContextInjection in favor of better solution Revert support for value and defaultValue inside iterate Ensure auto-closing mechanism works consistently – remove useUnmountEffect because of the lack of possible changing deps Ensure correct mount/unmount by using correct deps handling Rename `initial-open` to `initiallyOpen` Move value warning to its own PR #3886 Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/info.mdx Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/info.mdx Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/info.mdx
tujoworker
pushed a commit
that referenced
this pull request
Sep 10, 2024
## [10.47.0](v10.46.0...v10.47.0) (2024-09-10) ### 📝 Documentation * add component translations table to properties docs ([#3902](#3902)) ([66dd12e](66dd12e)) * **useTheme:** updates docs to match TS type definitions ([#3901](#3901)) ([52aaab3](52aaab3)) ### ✨ Features * **Button:** rewise documented `title` prop with aria-label documentation ([#3863](#3863)) ([ea444c0](ea444c0)) * **CopyOnClick:** adds copyContent prop ([e5a91b6](e5a91b6)) * **countries:** Added missing countries from ISO 3166 [#3894](#3894) ([2992084](2992084)) * **countries:** Added missing countries from ISO 3166 [#3894](#3894) ([#3899](#3899)) ([ada0e92](ada0e92)) * **Forms:** extend validations in `Field.NationalIdentityNumber` ([#3888](#3888)) ([50cc26b](50cc26b)) * **Forms:** make it possible to reuse and extend internal validators ([#3908](#3908)) ([7c97bf5](7c97bf5)) * **Forms:** provide `connectWithPath` in the validator and onBlurValidator to get values from other fields/paths ([#3895](#3895)) ([f4cf06f](f4cf06f)) * **Value.Date:** adds numeric variant ([#3907](#3907)) ([b03e199](b03e199)) ### 🐛 Bug Fixes * **Accordion:** deprecate (rename) expandBehaviour in favor of expandBehavior ([#3905](#3905)) ([76143b0](76143b0)) * **Breakpoint:** ensure matching breakpoint ranges in mixins with docs & hooks ([#3896](#3896)) ([260fcaf](260fcaf)) * **Flex:** enhance handling of React fragments ([#3892](#3892)) ([156c805](156c805)) * **Forms:** enhance cleanup routine of fields ([#3885](#3885)) ([388e0b2](388e0b2)), closes [#3877](#3877) * **Forms:** ensure label supports HTML formatting ([#3911](#3911)) ([227569c](227569c)) * **Forms:** ensure labels do update when they change (async fields) ([#3910](#3910)) ([bc40449](bc40449)) * **Forms:** warn on value prop usage on fields inside iterate with itemPath ([#3886](#3886)) ([116820d](116820d)), closes [#3877](#3877) [#3882](#3882) * **LabelDescription:** nothing was returned ([#3898](#3898)) ([3452855](3452855))
|
🎉 This PR is included in version 10.47.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
tujoworker
added a commit
that referenced
this pull request
Sep 10, 2024
…lbarWhen` property to Iterate.Array – show first item as initially open Close items when PushContainer opens Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/demos.mdx Co-authored-by: Anders <anderslangseth@gmail.com> Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/Examples.tsx Co-authored-by: Anders <anderslangseth@gmail.com> Ensure correct error message and avoid cancel click when item has error Revert useExternalValue path change Remove prioritizeDataContextInjection in favor of better solution Revert support for value and defaultValue inside iterate Ensure auto-closing mechanism works consistently – remove useUnmountEffect because of the lack of possible changing deps Ensure correct mount/unmount by using correct deps handling Rename `initial-open` to `initiallyOpen` Move value warning to its own PR #3886 Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/info.mdx Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/info.mdx Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/info.mdx
tujoworker
added a commit
that referenced
this pull request
Sep 11, 2024
…lbarWhen` property to Iterate.Array – show first item as initially open Close items when PushContainer opens Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/demos.mdx Co-authored-by: Anders <anderslangseth@gmail.com> Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/Examples.tsx Co-authored-by: Anders <anderslangseth@gmail.com> Ensure correct error message and avoid cancel click when item has error Revert useExternalValue path change Remove prioritizeDataContextInjection in favor of better solution Revert support for value and defaultValue inside iterate Ensure auto-closing mechanism works consistently – remove useUnmountEffect because of the lack of possible changing deps Ensure correct mount/unmount by using correct deps handling Rename `initial-open` to `initiallyOpen` Move value warning to its own PR #3886 Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/info.mdx Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/info.mdx Update packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/info.mdx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move out the warning from PR #3877 in regards of this issue #3882