Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve docs for hide_close_button of Modal #1072

Merged

Conversation

langz
Copy link
Contributor

@langz langz commented Oct 27, 2021

now vs. not

@gatsby-cloud
Copy link

gatsby-cloud bot commented Oct 27, 2021

Gatsby Cloud Build Report

DNB Eufemia Portal

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 6m

Performance

Lighthouse report

Metric Score
Performance 🔶 73
Accessibility 💚 100
Best Practices 💚 100
SEO 💚 92

🔗 View full report

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c9bb647:

Sandbox Source
eufemia-starter Configuration

@tujoworker
Copy link
Member

Duper duper 👍

@tujoworker tujoworker merged commit b452b38 into main Oct 28, 2021
@tujoworker tujoworker deleted the docs/improve-docs-for-hide-close-button-prop-of-modal branch October 28, 2021 06:53
@tujoworker
Copy link
Member

🎉 This PR is included in version 9.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants