Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move accessibility checklist for designers to menu #1198

Merged
merged 4 commits into from
Jan 14, 2022

Conversation

dinarosv
Copy link
Contributor

As described should be done (line 97, accessibility.md).

I also updated some links and information.

As described to be done (line 97, accessibility.md)
@dinarosv dinarosv requested review from langz and thaytharma January 14, 2022 09:23
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 14, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 34280a1:

Sandbox Source
eufemia-starter Configuration

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jan 14, 2022

Gatsby Cloud Build Report

DNB Eufemia Portal

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 8m

Performance

Lighthouse report

Metric Score
Performance 🔶 66
Accessibility 💚 100
Best Practices 💚 100
SEO 💚 92

🔗 View full report

@@ -6,7 +6,7 @@

/**
* Library Index avatar to autogenerate all the components and extensions
* Used by "prepareAvatar"
* Used by "prepareAvatars"
Copy link
Contributor

@langz langz Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙇

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was automatically added on build 👼 😁

Copy link
Contributor

@thaytharma thaytharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 😍
Just added two minor suggestions.

Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great docs 🎊

dinarosv and others added 3 commits January 14, 2022 11:30
…/accessibility/checklist.md

Co-authored-by: Thayanan Tharmapalan <thayanan@gmail.com>
…/accessibility/checklist.md

Co-authored-by: Thayanan Tharmapalan <thayanan@gmail.com>
…/accessibility/checklist.md

Co-authored-by: Anders <anderslangseth@gmail.com>
@dinarosv dinarosv merged commit e1505b5 into main Jan 14, 2022
@dinarosv dinarosv deleted the docs/design-checklist branch January 14, 2022 11:01
@tujoworker
Copy link
Member

🎉 This PR is included in version 9.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants