-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: move accessibility checklist for designers to menu #1198
Conversation
As described to be done (line 97, accessibility.md)
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 34280a1:
|
Gatsby Cloud Build ReportDNB Eufemia Portal 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 8m PerformanceLighthouse report
|
@@ -6,7 +6,7 @@ | |||
|
|||
/** | |||
* Library Index avatar to autogenerate all the components and extensions | |||
* Used by "prepareAvatar" | |||
* Used by "prepareAvatars" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was automatically added on build 👼 😁
packages/dnb-design-system-portal/src/docs/quickguide-designer/accessibility/checklist.md
Outdated
Show resolved
Hide resolved
packages/dnb-design-system-portal/src/docs/quickguide-designer/accessibility/checklist.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 😍
Just added two minor suggestions.
packages/dnb-design-system-portal/src/docs/quickguide-designer/accessibility/checklist.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great docs 🎊
…/accessibility/checklist.md Co-authored-by: Thayanan Tharmapalan <thayanan@gmail.com>
…/accessibility/checklist.md Co-authored-by: Thayanan Tharmapalan <thayanan@gmail.com>
…/accessibility/checklist.md Co-authored-by: Anders <anderslangseth@gmail.com>
🎉 This PR is included in version 9.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
As described should be done (line 97, accessibility.md).
I also updated some links and information.