Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tag): remove tag group warnings in tests #1214

Merged
merged 1 commit into from
Jan 25, 2022
Merged

fix(Tag): remove tag group warnings in tests #1214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 67 additions & 19 deletions packages/dnb-eufemia/src/components/tag/__tests__/Tag.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,23 @@ describe('Tag Group', () => {

describe('Tag', () => {
it('renders without properties', () => {
render(<Tag />)
render(
<Tag.Group label="tags">
<Tag />
</Tag.Group>
)

expect(screen.queryByTestId('tag')).not.toBeNull()
})

it('renders a tag with content by text prop', () => {
const text = 'This is a tag'

render(<Tag text="This is a tag" />)
render(
<Tag.Group label="tags">
<Tag text="This is a tag" />
</Tag.Group>
)

expect(
screen.queryByTestId('tag').querySelector('.dnb-button__text')
Expand All @@ -95,7 +103,11 @@ describe('Tag', () => {
it('renders a tag with content by children prop', () => {
const text = 'This is a tag'

render(<Tag>{text}</Tag>)
render(
<Tag.Group label="tags">
<Tag>{text}</Tag>
</Tag.Group>
)

expect(
screen.queryByTestId('tag').querySelector('.dnb-button__text')
Expand All @@ -109,7 +121,11 @@ describe('Tag', () => {
it('renders a tag with content if both text and children prop is defined', () => {
const text = 'This is a tag'

render(<Tag text={text}>{text}</Tag>)
render(
<Tag.Group label="tags">
<Tag text={text}>{text}</Tag>
</Tag.Group>
)

expect(
screen.queryByTestId('tag').querySelector('.dnb-button__text')
Expand All @@ -123,21 +139,33 @@ describe('Tag', () => {
it('renders a tag with skeleton if skeleton is true', () => {
const skeletonClassName = 'dnb-skeleton'

render(<Tag skeleton>ClassName</Tag>)
render(
<Tag.Group label="tags">
<Tag skeleton>ClassName</Tag>
</Tag.Group>
)
expect(screen.queryByTestId('tag').className).toMatch(
skeletonClassName
)
})

it('does not render a clickable Tag as default', () => {
render(<Tag text="Tag with text" />)
render(
<Tag.Group label="tags">
<Tag text="Tag with text" />
</Tag.Group>
)

expect(screen.queryByRole('button')).toBeNull()
expect(screen.queryByTestId('tag').textContent).toBe('‌Tag with text')
})

it('does support icon', () => {
render(<Tag text="Tag with icon" icon="bell" />)
render(
<Tag.Group label="tags">
<Tag text="Tag with icon" icon="bell" />
</Tag.Group>
)

expect(
screen.queryByTestId('tag').querySelector('.dnb-icon')
Expand All @@ -149,13 +177,15 @@ describe('Tag', () => {
const clickableClassName = 'dnb-tag--clickable'

render(
<Tag
onClick={() => {
console.log('onClick')
}}
>
Clickable
</Tag>
<Tag.Group label="tags">
<Tag
onClick={() => {
console.log('onClick')
}}
>
Clickable
</Tag>
</Tag.Group>
)
expect(screen.queryByTestId('tag').className).toMatch(
clickableClassName
Expand All @@ -166,14 +196,22 @@ describe('Tag', () => {

it('fires onClick event if onClick is defined', () => {
const onClick = jest.fn()
render(<Tag onClick={onClick}>onClick</Tag>)
render(
<Tag.Group label="tags">
<Tag onClick={onClick}>onClick</Tag>
</Tag.Group>
)

fireEvent.click(screen.getByRole('button'))
expect(onClick).toHaveBeenCalledTimes(1)
})

it('does support icon', () => {
render(<Tag text="Tag with icon" icon="bell" onClick={jest.fn()} />)
render(
<Tag.Group label="tags">
<Tag text="Tag with icon" icon="bell" onClick={jest.fn()} />
</Tag.Group>
)

expect(
screen.queryByTestId('tag').querySelector('.dnb-icon')
Expand All @@ -191,14 +229,20 @@ describe('Tag', () => {
it('renders a tag with className if className is provided', () => {
const customClassName = 'custom-class'

render(<Tag className={customClassName}>ClassName</Tag>)
render(
<Tag.Group label="tags">
<Tag className={customClassName}>ClassName</Tag>
</Tag.Group>
)
expect(screen.queryByTestId('tag').className).toMatch(customClassName)
})

it('renders a tag with provider', () => {
render(
<Provider locale="en-GB">
<Tag text="With provider" />
<Tag.Group label="tags">
<Tag text="With provider" />
</Tag.Group>
</Provider>
)

Expand All @@ -210,7 +254,11 @@ describe('Tag', () => {

describe('Tag aria', () => {
it('should validate', async () => {
const Component = render(<Tag text="Tag aria" />)
const Component = render(
<Tag.Group label="tags">
<Tag text="Tag aria" />
</Tag.Group>
)
expect(await axeComponent(Component)).toHaveNoViolations()
})
})
Expand Down