Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tag): update delete icon #1224

Merged
merged 1 commit into from
Jan 26, 2022
Merged

fix(Tag): update delete icon #1224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions packages/dnb-eufemia/src/components/tag/Tag.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,22 +169,19 @@ const Tag = (localProps: TagProps & ISpacingProps) => {
<svg
width="16"
height="16"
viewBox="0 0 16 16"
fill="none"
xmlns="http://www.w3.org/2000/svg"
>
<path
d="M0 8C0 3.58172 3.58172 0 8 0V0C12.4183 0 16 3.58172 16 8V8C16 12.4183 12.4183 16 8 16V16C3.58172 16 0 12.4183 0 8V8Z"
fill="white"
d="M0 8a8 8 0 1 1 16 0A8 8 0 1 1 0 8Z"
className="dnb-icon-close-circle-path"
/>
<path
d="M5.5 10.5L10.5 5.5M10.5 10.5L5.5 5.5"
stroke="#007272"
d="m5.5 10.5 5-5m0 5-5-5"
className="dnb-icon-close-cross-path"
strokeWidth="1.5"
strokeLinecap="round"
strokeLinejoin="round"
className="dnb-icon-close-cross-path"
/>
</svg>
}
Expand Down
4 changes: 4 additions & 0 deletions packages/dnb-eufemia/src/components/tag/__tests__/__snapshots__/Tag.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,6 +606,10 @@ button.dnb-button::-moz-focus-inner {
.dnb-tag--removable.dnb-button {
color: var(--color-white);
background-color: var(--color-sea-green); }
.dnb-tag--removable.dnb-button svg .dnb-icon-close-circle-path {
fill: var(--color-white); }
.dnb-tag--removable.dnb-button svg .dnb-icon-close-cross-path {
stroke: var(--color-sea-green); }
.dnb-tag--removable.dnb-button:focus[disabled],
html:not([data-whatintent='touch']) .dnb-tag--removable.dnb-button:focus[disabled] {
cursor: not-allowed; }
Expand Down
Binary file modified ...apshots__/tag-screenshot-test-js-have-to-match-a-removable-tag-1-3387d.snap.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ts__/tag-screenshot-test-js-have-to-match-a-removable-tag-list-1-f49cc.snap.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions packages/dnb-eufemia/src/components/tag/style/_tag.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
&.dnb-button {
color: var(--color-white);
background-color: var(--color-sea-green);
@include deleteIcon(var(--color-white), var(--color-sea-green));

@include buttonFocus(var(--color-sea-green), var(--color-white)) {
@include deleteIcon();
Expand Down