Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Slider): deprecate use_scrollwheel #1889

Merged
merged 1 commit into from
Jan 10, 2023
Merged

feat(Slider): deprecate use_scrollwheel #1889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/dnb-design-system-portal/src/docs/uilib/components/slider/properties.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,4 @@ showTabs: true
| `globalStatusId` | _(optional)_ the `status_id` used for the target [GlobalStatus](/uilib/components/global-status). |
| `suffix` | _(optional)_ text describing the content of the Slider more than the label. You can also send in a React component, so it gets wrapped inside the Slider component. |
| `skeleton` | _(optional)_ if set to `true`, an overlaying skeleton with animation will be shown. |
| ~~`use_scrollwheel`~~ | _(optional)_ enable mouse scroll-wheel support. Defaults to `false`. |
| [Space](/uilib/components/space/properties) | _(optional)_ spacing properties like `top` or `bottom` are supported. |
8 changes: 0 additions & 8 deletions packages/dnb-eufemia/src/components/slider/SliderProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import React from 'react'
import { includeValidProps } from '../../components/form-row/FormRowHelpers'
import {
warn,
isTrue,
makeUniqueId,
dispatchCustomElementEvent,
Expand Down Expand Up @@ -123,13 +122,6 @@ export function SliderProvider(localProps: SliderAllProps) {
}
}

/**
* Deprecated
*/
if (allProps.use_scrollwheel) {
warn('use_scrollwheel is not supported anymore!')
}

const getAndUpdateCurrentIndex = (currentValue: number) => {
let currentIndex = null

Expand Down
3 changes: 0 additions & 3 deletions packages/dnb-eufemia/src/components/slider/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,6 @@ export type SliderProps = IncludeSnakeCase<{
/** @deprecated */
onInit?: (props: Omit<onChangeEventProps, 'rawValue'>) => void

/** @deprecated The Slider does not support mouse wheel */
use_scrollwheel?: boolean

children?: React.ReactChild
}>

Expand Down