Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Modal, Dialog, Drawer): remove closeButtonAttributes #1926

Merged
merged 1 commit into from
Jan 18, 2023
Merged

feat(Modal, Dialog, Drawer): remove closeButtonAttributes #1926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/dnb-design-system-portal/src/docs/uilib/components/modal/prop-table.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,4 @@
| `spacing` | _(deprecated/optional)_ if set to `false` then the modal content will be shown without any spacing. Defaults to `true`. |
| `closeTitle` / `close_title` | _(deprecated/optional)_ the title of the close button. Defaults to _Lukk_. |
| `hideCloseButton` | _(deprecated/optional)_ if truthy, the close button will not be shown. |
| `closeButtonAttributes` | _(deprecated/optional)_ define any valid Eufemia Button property or HTML attribute inside an object. |
| `class` or `className` | _(deprecated/optional)_ give the inner content wrapper a class name (maps to `dnb-modal__content__inner`). |
1 change: 0 additions & 1 deletion packages/dnb-design-system-portal/src/shared/menu/PortalToolsMenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ export default function PortalToolsMenu({
</Tooltip>
),
}}
closeButtonAttributes={{ skeleton: false }}
{...props}
>
<Modal.Content spacing>
Expand Down
2 changes: 0 additions & 2 deletions packages/dnb-eufemia/src/components/dialog/Dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ function Dialog(
focusSelector,
labelledBy,
directDomReturn,
closeButtonAttributes,
disabled,

variant,
Expand Down Expand Up @@ -108,7 +107,6 @@ function Dialog(
dialogTitle,
closeTitle,
hideCloseButton: currentHideCloseButton,
closeButtonAttributes,
preventClose,
preventOverlayClose: currentPreventOverlayClose,
animationDuration,
Expand Down
2 changes: 0 additions & 2 deletions packages/dnb-eufemia/src/components/drawer/Drawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ function Drawer({
labelledBy,
directDomReturn,
hideCloseButton,
closeButtonAttributes,
disabled,

title,
Expand Down Expand Up @@ -74,7 +73,6 @@ function Drawer({
dialogTitle,
closeTitle,
hideCloseButton,
closeButtonAttributes,
preventClose,
preventOverlayClose,
animationDuration,
Expand Down
3 changes: 0 additions & 3 deletions packages/dnb-eufemia/src/components/modal/stories/Modal.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,9 +238,6 @@ export const ModalV2Sandbox = () => (
text: 'Custom',
'data-testid': 'html-selector',
}}
closeButtonAttributes={{
'data-testid': 'html-selector',
}}
>
The informational content
</Modal>
Expand Down