fix(Breadcrumb): ensure focus state is not partially hidden #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With PR #1860 we got this issue: By adding a visual test, simulating the focus state, we should avoid this in the future. Its fixed by removing the `overflow: hidden` – its not used actually, because our animation `HeightAnimation` will add&remove it during the animation anyway.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 29dc02c:
|
✅ DNB Eufemia Portal deploy preview ready
|
tujoworker
pushed a commit
that referenced
this pull request
Jan 29, 2023
## [9.46.2](v9.46.1...v9.46.2) (2023-01-29) ### Bug Fixes * **Breadcrumb:** ensure focus state is not partially hidden ([#1949](#1949)) ([954d570](954d570)), closes [#1860](#1860) * **Table:** fix fist border on rowSpan={2} is used in first column ([#1956](#1956)) ([48ff543](48ff543)) * **Table:** fix sticky table when in iFrame ([#1954](#1954)) ([ac4f254](ac4f254))
|
🎉 This PR is included in version 9.46.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
joakbjerk
pushed a commit
that referenced
this pull request
Mar 27, 2023
With PR #1860 we got this issue: By adding a visual test, simulating the focus state, we should avoid this in the future. Its fixed by removing the `overflow: hidden` – its not used actually, because our animation `HeightAnimation` will add&remove it during the animation anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🙏 Tack Micaela 🇸🇪
With PR #1563 we got this issue when focusing the item:
By adding a visual test, simulating the focus state, we should avoid this in the future.
We fix the issue by removing the
overflow: hidden– its not used anyway, because ourHeightAnimationwill add&remove it during the animation anyway.We also rename the visual test file (for v10 migration) and refactor the Example file.