feat(Skeleton): removes style_type prop

[langz]

Doesn't look like style_type is used, couldn't even find styles(.scss code) matching dnb-skeleton--${style_type}.
If we think we'll add skeleton styles in the near future, we may of course keep this though 🙏

[netlify]

✅ Deploy Preview for eufemia ready!

Name	Link
🔨 Latest commit	3a9c7f2
🔍 Latest deploy log	https://app.netlify.com/sites/eufemia/deploys/641056711d56e00008d09f41
😎 Deploy Preview	https://deploy-preview-2095--eufemia.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3a9c7f2:

Sandbox	Source
eufemia-starter	Configuration

[tujoworker]

Yes, true, for consistency, we should remove this feature.

We did use it to set a CSS modifier: dnb-skeleton--${style_type}

There are a couple of extra theme files, that are related to this too:

https://github.com/dnbexperience/eufemia/tree/v10/packages/dnb-eufemia/src/components/skeleton/style/themes

[langz]

Yes, true, for consistency, we should remove this feature.

We did use it to set a CSS modifier: dnb-skeleton--${style_type}

There are a couple of extra theme files, that are related to this too:

https://github.com/dnbexperience/eufemia/tree/v10/packages/dnb-eufemia/src/components/skeleton/style/themes

Thanks, I've tried to remove these files as part of this PR as well 🙏
I think it was safe to remove the styles &--lines, even though the docs said that style_type Defaults to lines, but that wasn't really true, as it defaulted to null and the class dnb-skeleton--${style_type} was only set when showSkeleton && style_type && `dnb-skeleton--${style_type}. So how I see it, this could be a breaking change in certain scenarios where applications have set style_type to lines and expect/need the styling removed here: https://github.com/dnbexperience/eufemia/pull/2095/files#diff-40855dd84485e98b1e7f99b0ea3cf1e25cca2830f241df0498252c07cbb24797L24-L25

Do you think we should list this as a breaking change or not @tujoworker ?

[tujoworker]

Do you think we should list this as a breaking change or not @tujoworker ?

This component was created with some flexibility in mind. But we have since seen the news to rather foster consistency.

I don't think it would have been UX driven to use a different variant/style. And if someone would have used "shine", it would not be "critical" if the style changes for those in v10. It's not a breaking change in my eyes, just because of the circumstances mentioned. But you could mention it in the EUFEMIA_CHANGELOG file. Maybe?

[langz]

Do you think we should list this as a breaking change or not @tujoworker ?

This component was created with some flexibility in mind. But we have since seen the news to rather foster consistency.

I don't think it would have been UX driven to use a different variant/style. And if someone would have used "shine", it would not be "critical" if the style changes for those in v10. It's not a breaking change in my eyes, just because of the circumstances mentioned. But you could mention it in the EUFEMIA_CHANGELOG file. Maybe?

Great, thanks, I'll now added it to the EUFEMIA_CHANGELOG file 🙏

[tujoworker]

🎉 This PR is included in version 10.0.0-beta.3 🎉

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot 📦🚀