Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor integration tests to TypeScript #2105

Merged
merged 16 commits into from
Mar 16, 2023
Merged

chore: refactor integration tests to TypeScript #2105

merged 16 commits into from
Mar 16, 2023

Conversation

tujoworker
Copy link
Member

I want to add tests for PR #2103 – but I want to do it in TS files. So this is a simple refactor of almost all tests. But not all. Just the easy once 😁

@netlify
Copy link

netlify bot commented Mar 15, 2023 •
edited
Loading

✅ Deploy Preview for eufemia ready!

Name Link
🔨 Latest commit f36889d
🔍 Latest deploy log https://app.netlify.com/sites/eufemia/deploys/6412d5e55f5d87000862de35
😎 Deploy Preview https://deploy-preview-2105--eufemia.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 15, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f36889d:

Sandbox Source
eufemia-starter Configuration

@tujoworker tujoworker force-pushed the chore/refactor-tests-to-ts branch 2 times, most recently from afef835 to ff7cce6 Compare March 15, 2023 21:28
@tujoworker tujoworker mentioned this pull request Mar 16, 2023
Merged
@tujoworker tujoworker marked this pull request as ready for review March 16, 2023 07:44
@tujoworker tujoworker requested review from langz and joakbjerk March 16, 2023 07:44
langz
langz approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍
Feels super nice adding more TypeScript, which results in us removing old/outdated properties from tests, etc which shouldn't be supported 👏

@tujoworker tujoworker force-pushed the chore/refactor-tests-to-ts branch from 65584be to f36889d Compare March 16, 2023 08:40
@tujoworker tujoworker merged commit cb30cd7 into v10 Mar 16, 2023
@tujoworker tujoworker deleted the chore/refactor-tests-to-ts branch March 16, 2023 09:00
joakbjerk pushed a commit that referenced this pull request Mar 27, 2023
@tujoworker @joakbjerk
chore: refactor (almost all) integration tests to TypeScript (#2105)
7c97881 
* chore: convert ToggleButton to TypeScript

* chore: convert Textarea to TypeScript

* chore: convert Switch to TypeScript

* chore: convert Radio to TypeScript

* chore: convert Logo to TypeScript

* chore: convert InputMasked to TypeScript

* chore: convert Input to TypeScript

* chore: convert IconPrimary to TypeScript

* chore: convert Icon to TypeScript

* chore: convert GlobalError to TypeScript

* chore: convert FormSet to TypeScript

* chore: convert FormRow to TypeScript

* chore: convert FormLabel to TypeScript

* chore: convert Button to TypeScript

* chore: convert Accordion to TypeScript

* chore: convert Checkbox to TypeScript
@langz langz mentioned this pull request Apr 18, 2023
Merged
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 10.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

langz pushed a commit that referenced this pull request May 31, 2023
@tujoworker @langz
chore: refactor (almost all) integration tests to TypeScript (#2105)
ee68ea6 
* chore: convert ToggleButton to TypeScript

* chore: convert Textarea to TypeScript

* chore: convert Switch to TypeScript

* chore: convert Radio to TypeScript

* chore: convert Logo to TypeScript

* chore: convert InputMasked to TypeScript

* chore: convert Input to TypeScript

* chore: convert IconPrimary to TypeScript

* chore: convert Icon to TypeScript

* chore: convert GlobalError to TypeScript

* chore: convert FormSet to TypeScript

* chore: convert FormRow to TypeScript

* chore: convert FormLabel to TypeScript

* chore: convert Button to TypeScript

* chore: convert Accordion to TypeScript

* chore: convert Checkbox to TypeScript
tujoworker added a commit that referenced this pull request May 31, 2023
@tujoworker
chore: refactor (almost all) integration tests to TypeScript (#2105)
40f6751 
* chore: convert ToggleButton to TypeScript

* chore: convert Textarea to TypeScript

* chore: convert Switch to TypeScript

* chore: convert Radio to TypeScript

* chore: convert Logo to TypeScript

* chore: convert InputMasked to TypeScript

* chore: convert Input to TypeScript

* chore: convert IconPrimary to TypeScript

* chore: convert Icon to TypeScript

* chore: convert GlobalError to TypeScript

* chore: convert FormSet to TypeScript

* chore: convert FormRow to TypeScript

* chore: convert FormLabel to TypeScript

* chore: convert Button to TypeScript

* chore: convert Accordion to TypeScript

* chore: convert Checkbox to TypeScript
tujoworker added a commit that referenced this pull request May 31, 2023
@tujoworker
chore: refactor (almost all) integration tests to TypeScript (#2105)
46fbe55 
* chore: convert ToggleButton to TypeScript

* chore: convert Textarea to TypeScript

* chore: convert Switch to TypeScript

* chore: convert Radio to TypeScript

* chore: convert Logo to TypeScript

* chore: convert InputMasked to TypeScript

* chore: convert Input to TypeScript

* chore: convert IconPrimary to TypeScript

* chore: convert Icon to TypeScript

* chore: convert GlobalError to TypeScript

* chore: convert FormSet to TypeScript

* chore: convert FormRow to TypeScript

* chore: convert FormLabel to TypeScript

* chore: convert Button to TypeScript

* chore: convert Accordion to TypeScript

* chore: convert Checkbox to TypeScript
tujoworker added a commit that referenced this pull request May 31, 2023
@tujoworker
chore: refactor (almost all) integration tests to TypeScript (#2105)
a4a6c6e 
* chore: convert ToggleButton to TypeScript

* chore: convert Textarea to TypeScript

* chore: convert Switch to TypeScript

* chore: convert Radio to TypeScript

* chore: convert Logo to TypeScript

* chore: convert InputMasked to TypeScript

* chore: convert Input to TypeScript

* chore: convert IconPrimary to TypeScript

* chore: convert Icon to TypeScript

* chore: convert GlobalError to TypeScript

* chore: convert FormSet to TypeScript

* chore: convert FormRow to TypeScript

* chore: convert FormLabel to TypeScript

* chore: convert Button to TypeScript

* chore: convert Accordion to TypeScript

* chore: convert Checkbox to TypeScript
tujoworker added a commit that referenced this pull request May 31, 2023
@tujoworker
chore: refactor (almost all) integration tests to TypeScript (#2105)
c42f968 
* chore: convert ToggleButton to TypeScript

* chore: convert Textarea to TypeScript

* chore: convert Switch to TypeScript

* chore: convert Radio to TypeScript

* chore: convert Logo to TypeScript

* chore: convert InputMasked to TypeScript

* chore: convert Input to TypeScript

* chore: convert IconPrimary to TypeScript

* chore: convert Icon to TypeScript

* chore: convert GlobalError to TypeScript

* chore: convert FormSet to TypeScript

* chore: convert FormRow to TypeScript

* chore: convert FormLabel to TypeScript

* chore: convert Button to TypeScript

* chore: convert Accordion to TypeScript

* chore: convert Checkbox to TypeScript
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langz langz langz approved these changes

@joakbjerk joakbjerk Awaiting requested review from joakbjerk

Assignees
No one assigned
Labels
released on @beta
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tujoworker @langz