Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Icons): move all icons assets to dnb subfolder: assets/icons/dnb/*.svg #2187

Merged
merged 3 commits into from
Mar 31, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion packages/dnb-design-system-portal/src/docs/icons.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import ListAllIcons from 'dnb-design-system-portal/src/shared/parts/icons/ListAl
This is a list of all icons available sorted in categories. Its a list where primary and secondary icons are combined. You may be interested to [read more](/icons/details) about what [the difference](/icons/primary) is and [how to import](/icons/secondary#react-example-usage).

- for Web there are both [icons as SVG](https://github.com/dnbexperience/eufemia/tree/main/packages/dnb-eufemia/assets/icons) and ready to use [React Components](/icons/secondary#react-example-usage).
joakbjerk marked this conversation as resolved.
Show resolved Hide resolved
- for Android there is a [custom XML (drawable) package](https://github.com/dnbexperience/eufemia/tree/main/packages/dnb-eufemia/assets/icons/eufemia-icons-xml.tgz) and a [categorized XML (drawable) package](https://github.com/dnbexperience/eufemia/tree/main/packages/dnb-eufemia/assets/icons/eufemia-icons-xml-categorized.tgz).
- for Android there is a [custom XML (drawable) package](https://github.com/dnbexperience/eufemia/tree/main/packages/dnb-eufemia/assets/icons/dnb/eufemia-icons-xml.tgz) and a [categorized XML (drawable) package](https://github.com/dnbexperience/eufemia/tree/main/packages/dnb-eufemia/assets/icons/dnb/eufemia-icons-xml-categorized.tgz).
- the support for iOS with the PDF format was discontinued in [v10](/uilib/about-the-lib/releases/eufemia/v10-info/).

<ListAllIcons groupBy="category" />
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,10 @@ do not contain the properties anymore. Properties are only a part of a theme fil

As long as you don't import them in your application, you don't need to make any changes in your codebase.

### SVG assets

All `svg` icon files were moved inside a subfolder in `/assets/icons/dnb/...`.

### StepIndicator

1. Find the `active_item` property and replace it with `current_step`.
Expand Down
4 changes: 2 additions & 2 deletions packages/dnb-eufemia/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
/umd
/style
/icons
/assets/icons/*.pdf
/assets/icons/*.xml
/assets/icons/*/*.pdf
/assets/icons/*/*.xml
/dnb-ui-resources
**/test-files/dist
/docs
Expand Down
Loading