feat(Button): sbanken css refactoring #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 65aa66a:
|
tujoworker
approved these changes
Aug 17, 2023
| @@ -170,29 +175,18 @@ | |||
| padding-right: 0; | |||
| margin-right: 1rem; | |||
|
|
|||
| // underline | |||
| // underlinex | |||
There was a problem hiding this comment.
Suggested change
| // underlinex | |
| // underline |
snorrekim
force-pushed
the
feat/button-sbanken-tertiary-fixes
branch
from
de54c46 to
7ab12b5
Compare
snorrekim
changed the title
snorrekim
force-pushed
the
feat/button-sbanken-tertiary-fixes
branch
from
7ab12b5 to
65aa66a
Compare
tujoworker
pushed a commit
that referenced
this pull request
Aug 23, 2023
## [10.7.0](v10.6.0...v10.7.0) (2023-08-23) ### 🐛 Bug Fixes * **Forms:** Fix provider rerender issue and FlexContainer spacing issue ([#2570](#2570)) ([aafdbc1](aafdbc1)) * **Forms:** sets SubHeading's size to medium ([#2581](#2581)) ([7e2ccbf](7e2ccbf)) ### ✨ Features * **Button:** sbanken css refactoring ([#2565](#2565)) ([3b9d6b0](3b9d6b0)) * **FormLabel:** sbanken ([#2563](#2563)) ([308a0b6](308a0b6)) * **FormRow:** sbanken theme ([#2564](#2564)) ([968efdd](968efdd)) * **Forms:** Field width features upgraded ([#2580](#2580)) ([73b1650](73b1650)) * **Pagination:** sbanken theme ([#2569](#2569)) ([d08a492](d08a492)) * **PaymentCard:** adds card_status not_active ([#2578](#2578)) ([03469e6](03469e6)) * **Section:** Sbanken styling and new variant prop ([#2582](#2582)) ([416db6d](416db6d))
|
🎉 This PR is included in version 10.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reduction of css specificity. The goal is not necessarily to make it more readable, but to make it easier to theme and customise.