fix(InputMasked): correct cursor position when navigating using keyboard #3160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 95c276f:
|
|
Thank you so much for addressing this issue and adding a very well written test! 🙏 I'v added a possible solution. This should be tested extensively. Also, possibly we should dive deeper into the origin of this issue, as the helper function Here is a CSB reprod. |
tujoworker
changed the title
tujoworker
approved these changes
Jan 9, 2024
tujoworker
force-pushed
the
test/input-masked-keyboard-navigation
branch
from
259f562 to
95c276f
Compare
tujoworker
pushed a commit
that referenced
this pull request
Jan 11, 2024
## [10.17.0](v10.16.0...v10.17.0) (2024-01-11) ### 📝 Documentation * refactor custom field component docs and example ([#3193](#3193)) ([3871079](3871079)) ### ✨ Features * **Anchor:** blank target icon styling ([#3172](#3172)) ([2ca216a](2ca216a)) * **DatePicker:** add onFocus event ([#3188](#3188)) ([2062213](2062213)) * **Field.Number:** add step control functionality ([#3140](#3140)) ([a9e1697](a9e1697)) * **Form.Visibility:** add `pathValue` and `whenValue` ([#3206](#3206)) ([8a547ae](8a547ae)) ### 🐛 Bug Fixes * **Autocomplete:** only set aria-controls attribute when expanded ([#3180](#3180)) ([a16a7ba](a16a7ba)) * **DatePicker:** add return object for onBlur ([#3178](#3178)) ([18b3889](18b3889)) * **DatePicker:** fix bug where minDate set to today is disabled ([#3176](#3176)) ([ef65676](ef65676)) * **Dropdown:** correct aria-controls target element ([#3181](#3181)) ([bc26101](bc26101)) * **Field.Currency:** handle big numbers ([#3184](#3184)) ([b856a46](b856a46)), closes [#3124](#3124) [#3185](#3185) * **Field.Number:** replace `rightAligned` prop with `align` ([#3175](#3175)) ([ba130ba](ba130ba)) * **FieldBlock:** ensure extra spacing of labels when on small screens ([#3187](#3187)) ([c86c857](c86c857)), closes [#3102](#3102) * **FieldBlock:** label can be clicked after focusing input ([#3190](#3190)) ([95b37e7](95b37e7)), closes [#2979](#2979) * **Flex.Container:** add `Flex.withChildren` HOC for handling wrapped children with spacing ([#3200](#3200)) ([93df77c](93df77c)) * **Flex.Container:** show line divider even when heading is present ([#3198](#3198)) ([d135b47](d135b47)) * **Form.Visibility:** move Visibility to Form.Visibility ([#3205](#3205)) ([d3b766f](d3b766f)) * **InputMasked:** correct cursor position when navigating using keyboard ([#3160](#3160)) ([9143b38](9143b38)) * **InputMasked:** extend reliability on cursor position correction ([#3194](#3194)) ([cbc27ac](cbc27ac)), closes [#3160](#3160) * **MultiInputMask:** enhance handling of right, left and backspace key usage ([#3192](#3192)) ([f3ce934](f3ce934)) * **PhoneNumber:** show read outline on both fields in error state ([#3196](#3196)) ([16ed821](16ed821)) * **Textarea:** ensure correct height based on rows for Firefox browser ([#3207](#3207)) ([75f754e](75f754e)) * **Visibility:** add support for being used in Flex.Container ([#3203](#3203)) ([7a72fa6](7a72fa6))
|
🎉 This PR is included in version 10.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are tabbing into an
InputMaskedfield which is partially filled and then uses your keyboard to un-select it by clicking your right arrow key, your input is ignored.Steps to reproduce:
Work around:
Set the
show_guideproperty tofalse