Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Field.Date): wrap in FieldBlock #3189

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

tujoworker
Copy link
Member

@tujoworker tujoworker commented Jan 8, 2024

Relies on #3188 and will be rebased once it is in main: ✅

Copy link

vercel bot commented Jan 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 7:37pm

@tujoworker tujoworker changed the title chore(Field.Date): add FieldBlock chore(Field.Date): wrap in FieldBlock Jan 8, 2024
@tujoworker tujoworker force-pushed the fix/date-field-block branch from feb8184 to 361046d Compare January 8, 2024 12:55
@tujoworker tujoworker requested a review from joakbjerk January 8, 2024 12:55
@tujoworker tujoworker marked this pull request as ready for review January 8, 2024 12:55
@tujoworker tujoworker force-pushed the fix/date-field-block branch 2 times, most recently from 10de279 to 6901839 Compare January 8, 2024 13:07
Copy link

codesandbox-ci bot commented Jan 8, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 06c624c:

Sandbox Source
eufemia-starter Configuration

Copy link
Contributor

@joakbjerk joakbjerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we perhaps set a default width so the component is not so wide out of the box?
Screenshot 2024-01-08 at 14 39 21

and the error styling seems to not be applied anymore
Screenshot 2024-01-08 at 14 40 52

@tujoworker tujoworker force-pushed the fix/date-field-block branch from 53ef8f3 to 06c624c Compare January 8, 2024 19:30
@tujoworker
Copy link
Member Author

Yes! Nice you check the actual outcome 🥇 – I've added two visual tests now ✅
Also, we do not handle width, as we are better with the given width. Also for future compatibility for date-range support.

Copy link
Contributor

@joakbjerk joakbjerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks perfect now! 🔥

@tujoworker tujoworker merged commit 4fdbf56 into main Jan 9, 2024
10 checks passed
@tujoworker tujoworker deleted the fix/date-field-block branch January 9, 2024 07:00
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 10.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants