Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Field): show error state without error object if parent FieldBlock has error #3225

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

snorrekim
Copy link
Contributor

Fixes #2958

The hasError prop is used to tell "regular" input components that they have an error

Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 4:24pm

@snorrekim snorrekim requested a review from tujoworker January 15, 2024 12:39
Copy link

codesandbox-ci bot commented Jan 15, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 442229c:

Sandbox Source
eufemia-starter Configuration

Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Looks good.

Would be great to have tests these cases as well 🚀

@snorrekim snorrekim force-pushed the fix/error-style-for-fields-in-field-block branch from b125a08 to 442229c Compare January 17, 2024 16:17
@snorrekim snorrekim merged commit 35fe238 into main Jan 17, 2024
10 checks passed
@snorrekim snorrekim deleted the fix/error-style-for-fields-in-field-block branch January 17, 2024 17:03
tujoworker pushed a commit that referenced this pull request Jan 22, 2024
## [10.19.0](v10.18.0...v10.19.0) (2024-01-22)

### 🐛 Bug Fixes

* **Autocomplete:** replace existing aria-live handling with the AriaLive component  ([#3258](#3258)) ([0ec06ca](0ec06ca))
* **Breadcrumb:** fix rehydration disturbance ([#3254](#3254)) ([dcf3a8b](dcf3a8b)), closes [#2762](#2762) [#2671](#2671)
* **DrawerList:** update original data when data prop changes ([#3247](#3247)) ([d1b03c2](d1b03c2))
* **Field:** show error state without error object if parent FieldBlock has error ([#3225](#3225)) ([35fe238](35fe238)), closes [#2958](#2958)
* **Flex.Container:** ensure rowGap=false has effect ([#3242](#3242)) ([e18ddfd](e18ddfd))
* **forms:** rename `contents` to `content` ([#3257](#3257)) ([2c9a397](2c9a397))
* **Input:** should not clear input value with escape key ([#3235](#3235)) ([979b3e3](979b3e3))
* **PhoneNumber:** handle pattern, schema and validator with country code ([#3249](#3249)) ([ed115d5](ed115d5))
* **Table.Accordion:** prevent accordion from opening on label click ([#3228](#3228)) ([ee5014f](ee5014f))
* **Textarea:** correct outline to be inset ([#3237](#3237)) ([6433470](6433470))

### ✨ Features

* **AriaLive:** add new component ([#3217](#3217)) ([7c79a54](7c79a54))
* **Flex:** add `line-framed` to divider ([#3244](#3244)) ([1aa3338](1aa3338)), closes [#3242](#3242) [#3245](#3245)
* **forms:** add labelDescription prop to fields (`labelSecondary` got removed) ([#3251](#3251)) ([00c278c](00c278c)), closes [#3209](#3209) [#3252](#3252)
* **NumberUtils.format:** Only return object if returnAria: true ([#3262](#3262)) ([ca4315f](ca4315f))
* **Section:** add support for backgroundColor=transparent ([#3255](#3255)) ([07e1545](07e1545))
* **Textarea:** add characterCounter ([#3210](#3210)) ([5c9dde9](5c9dde9)), closes [#3217](#3217)
* **TextCounter:** add new fragment used in Textarea ([#3250](#3250)) ([3093c28](3093c28)), closes [#3210](#3210)
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

bug(Field.PostalCodeAndCity): postalcode field doesn't display a red error border when error
3 participants