Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): added handle to collapse all accordion rows #3666

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

snorrekim
Copy link
Contributor

@snorrekim snorrekim commented Jun 6, 2024

  • added prop collapseAllHandleRef that exposes a ref handle that can be called to collapse all expanded rows in a table
  • refactor useTableAccordion into a component <TableAccordion> as that makes more sense in this case

Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 1:35pm

@snorrekim snorrekim force-pushed the feat/table-accordion-collapse-all branch 2 times, most recently from 7f13db6 to 9ad7523 Compare June 6, 2024 11:43
@snorrekim snorrekim changed the title added collapse all ref handle feat(Table): added handle to collapse all accordion rows Jun 7, 2024
@snorrekim snorrekim marked this pull request as ready for review June 7, 2024 09:11
@snorrekim snorrekim requested a review from tujoworker June 7, 2024 09:11
Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Thank you 💯

@tujoworker tujoworker merged commit c09a697 into main Jun 11, 2024
9 checks passed
@tujoworker tujoworker deleted the feat/table-accordion-collapse-all branch June 11, 2024 09:36
tujoworker pushed a commit that referenced this pull request Jun 11, 2024
## [10.35.0](v10.34.1...v10.35.0) (2024-06-11)

### 📝 Documentation

* add link to Eufemia's GitHub repository in menu bar ([#3670](#3670)) ([cdecbb3](cdecbb3))
* fix heading levels ([#3660](#3660)) ([d0bb28d](d0bb28d))
* **Forms:** fix broken link to forms/Wizard/Container ([#3656](#3656)) ([53cb041](53cb041))
* **Forms:** reqruied -> required ([#3655](#3655)) ([be82a51](be82a51))
* remove demos ([#3668](#3668)) ([90638ce](90638ce))

### 🐛 Bug Fixes

* add support for ::selection color for Chromium based browsers ([#3689](#3689)) ([6e49a9b](6e49a9b))
* **forms:** add help button to Field.Option ([#3678](#3678)) ([9210281](9210281))
* **forms:** ensure help button is rendered only once in Toggle and Boolean fields ([#3675](#3675)) ([d9e9478](d9e9478))
* **forms:** solve issue when schema is used in Wizard ([#3680](#3680)) ([8699b0c](8699b0c))
* **TextCounter:** exceeded message when variant up ([#3688](#3688)) ([22f1507](22f1507))

### ✨ Features

* **assets:** add sbanken logo svgs ([#3674](#3674)) ([1d7bcc0](1d7bcc0))
* **filter:** add support to filter array data based on wildcard `*` ([#3679](#3679)) ([1d93ac4](1d93ac4))
* **forms:** add edit and view containers to `Form.Section` ([#3652](#3652)) ([51bf7a2](51bf7a2))
* **forms:** add help property to ArraySelection field ([#3694](#3694)) ([f6b1224](f6b1224))
* **HelpButton:** ensure larger bounding area when size is set to small ([#3677](#3677)) ([97ca056](97ca056))
* **Logo:** Refactor Logo to ts ([#3611](#3611)) ([b1ca771](b1ca771))
* **NumberFormat:** add monospace support ([#3669](#3669)) ([940ddb6](940ddb6))
* refactor internal translation logic to not mutate the root context ([#3691](#3691)) ([49b0b45](49b0b45))
* **Table:** added handle to collapse all accordion rows ([#3666](#3666)) ([c09a697](c09a697))
* **Translation:** add support for type-safe keys ([#3681](#3681)) ([437ba83](437ba83))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants