Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Field.PhoneNumber): document onChange event args #3807

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

snorrekim
Copy link
Contributor

@snorrekim snorrekim commented Aug 12, 2024

  • added portal documentation for second argument of onChange(value, additionalArgs) event.
  • added onCountryCodeChange and onNumberChange events to portal documentation
  • added helper for general field event types

Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 1:25pm

Copy link

codesandbox-ci bot commented Aug 12, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great🫡
I changed the PR title from feat(Field.PhoneNumber): document onChange event args to docs(Field.PhoneNumber): document onChange event args 📒

@langz langz changed the title feat(Field.PhoneNumber): document onChange event args docs(Field.PhoneNumber): document onChange event args Aug 12, 2024
@snorrekim snorrekim merged commit 2b5f55e into main Aug 13, 2024
10 checks passed
@snorrekim snorrekim deleted the feat/phone-number-events-documentation branch August 13, 2024 14:01
tujoworker pushed a commit that referenced this pull request Aug 19, 2024
## [10.44.0](v10.43.0...v10.44.0) (2024-08-19)

### 📝 Documentation

* **Field.Expiry:** display translation props ([#3815](#3815)) ([1efbbd0](1efbbd0))
* **Field.PhoneNumber:** document onChange event args ([#3807](#3807)) ([2b5f55e](2b5f55e))
* **Form.Isolation:** add real world examples ([#3808](#3808)) ([daec2fa](daec2fa))

### 🐛 Bug Fixes

* **Button:** onClick can now be set using context provider ([#3781](#3781)) ([0d2f525](0d2f525))
* **forms:** add `Form.Isolation` path support when used inside `Form.Section` ([#3829](#3829)) ([d836c18](d836c18))
* **forms:** ensure correct spacing between `Iterate.Array` items ([#3838](#3838)) ([250aec0](250aec0))
* **forms:** ensure Form.Isolated does merge data properly ([#3811](#3811)) ([8c90cb8](8c90cb8)), closes [#3806](#3806)
* **forms:** ensure Form.Isolation with commitHandleRef triggers field errors ([#3810](#3810)) ([204396d](204396d))
* **forms:** show error when entered `Field.Currency` or `Field.Number` value exceeds maximum possible amount ([#3821](#3821)) ([e9cdd68](e9cdd68))

### ✨ Features

* **Field.PhoneNumber, Field.SelectCountry:** additional event args for onFocus and onBlur ([#3820](#3820)) ([1da5d4f](1da5d4f))
* **Field:** adds typing for event callbacks ([#3830](#3830)) ([2275002](2275002))
* **Form:** continuousValidation did not update error state correctly ([#3804](#3804)) ([5ff74bd](5ff74bd))
* **forms:** add `dataPath` prop to Field.Selection ([#3816](#3816)) ([e43ad59](e43ad59))
* **forms:** add `Form.clearData` method to remove existing/shared data forms with an id ([#3809](#3809)) ([acf4c7f](acf4c7f)), closes [#3803](#3803) [/github.com//issues/3803#issuecomment-2283661946](https://github.com/dnbexperience//github.com/dnbexperience/eufemia/issues/3803/issues/issuecomment-2283661946)
* **forms:** add `transformOnCommit` to Form.Isolation ([#3813](#3813)) ([21eca1a](21eca1a)), closes [#3812](#3812) [#3808](#3808)
* **forms:** add path prop support to Form.Isolation ([#3812](#3812)) ([a16d782](a16d782)), closes [#3811](#3811)
* **Forms:** seperate translations for Boolean and Toggle ([#3819](#3819)) ([fa0827b](fa0827b))
* **Upload:** enables disabling of fileMaxSize ([#3835](#3835)) ([f2eff23](f2eff23))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.44.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants