Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Forms): add Value.Upload component #4233

Merged
merged 16 commits into from
Nov 8, 2024
Merged

feat(Forms): add Value.Upload component #4233

merged 16 commits into from
Nov 8, 2024

Conversation

langz
Copy link
Contributor

@langz langz commented Nov 6, 2024 •
edited
Loading

Adds Value.Upload component

@vercel Vercel
Copy link

vercel bot commented Nov 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 2:16pm

@langz langz changed the title docs: temp feat(Forms): add Value.Upload component Nov 6, 2024
@langz langz marked this pull request as draft November 6, 2024 14:44
@langz langz force-pushed the feat/value-upload branch from a52b5cb to adb8eef Compare November 6, 2024 14:44
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Nov 6, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@langz langz force-pushed the feat/value-upload branch from adb8eef to 9296f78 Compare November 7, 2024 14:32
@langz langz force-pushed the feat/value-upload branch from 8161fcd to a20c295 Compare November 7, 2024 22:30
@langz langz marked this pull request as ready for review November 8, 2024 11:53
@langz langz requested a review from tujoworker November 8, 2024 11:58
@langz langz force-pushed the feat/value-upload branch 2 times, most recently from 92b97f2 to a5e5995 Compare November 8, 2024 13:09
@langz langz force-pushed the feat/value-upload branch from 22ace47 to 2eddf74 Compare November 8, 2024 13:14
@langz langz force-pushed the feat/value-upload branch from b4ccd5b to 4ee0bfb Compare November 8, 2024 13:31
@langz langz force-pushed the feat/value-upload branch from 4ee0bfb to 68bd389 Compare November 8, 2024 13:32
tujoworker
tujoworker approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just a couple of code comments 👍

packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Value/Upload/Examples.tsx Outdated Show resolved Hide resolved
packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Value/Upload/info.mdx Outdated Show resolved Hide resolved
packages/dnb-eufemia/src/components/upload/__tests__/UploadFileListCell.test.tsx Show resolved Hide resolved
packages/dnb-eufemia/src/extensions/forms/Value/Upload/Upload.tsx Outdated Show resolved Hide resolved
packages/dnb-eufemia/src/extensions/forms/Value/Upload/Upload.tsx Outdated Show resolved Hide resolved
packages/dnb-eufemia/src/extensions/forms/Value/Upload/Upload.tsx Outdated Show resolved Hide resolved
packages/dnb-eufemia/src/extensions/forms/Value/Upload/Upload.tsx Outdated Show resolved Hide resolved
packages/dnb-eufemia/src/extensions/forms/Value/Upload/Upload.tsx Outdated Show resolved Hide resolved
packages/dnb-eufemia/src/extensions/forms/Value/Upload/Upload.tsx Outdated Show resolved Hide resolved
packages/dnb-eufemia/src/extensions/forms/Value/Upload/Upload.tsx Outdated Show resolved Hide resolved
langz and others added 2 commits November 8, 2024 14:45
@langz
update exampels
c596b76
@langz @tujoworker
Update packages/dnb-design-system-portal/src/docs/uilib/extensions/fo…
db36f7f 
…rms/Value/Upload/Examples.tsx

Co-authored-by: Tobias Høegh <tobias@tujo.no>
tujoworker
tujoworker reviewed Nov 8, 2024
View reviewed changes
packages/dnb-design-system-portal/src/docs/uilib/components/upload/Examples.tsx Outdated
})
return file
}
import { createMockFile } from '@dnb/eufemia/src/components/upload/__tests__/testHelpers'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't import them for inside tests – but rather export it from one of the upload Examples.tsx files and import it in the other one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okok, I'll do so then 🫡

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this better?
ab59727

@langz langz merged commit 3adddac into main Nov 8, 2024
10 checks passed
@langz langz deleted the feat/value-upload branch November 8, 2024 14:25
tujoworker pushed a commit that referenced this pull request Nov 8, 2024
@semantic-release-bot
chore(release): 10.55.0 [skip ci]
2c5d955 
## [10.55.0](v10.54.1...v10.55.0) (2024-11-08)

### ⚡ Refactoring

* center cards on ultra-wide monitors and fix capitalization typo ([#4214](#4214)) ([0ec1388](0ec1388))

### 📝 Documentation

* **CountryFlag:** `iso` defaults to `NO` ([#4234](#4234)) ([cab3c32](cab3c32))
* display all Value components in the Value menu ([#4231](#4231)) ([d260a9c](d260a9c))

### 🐛 Bug Fixes

* ensure components having `fieldset` inside still can use spacing ([#4236](#4236)) ([d4e4334](d4e4334))
* **Forms:** add Iterate support for Field.PostalCodeAndCity when using `country` with a path ([#4215](#4215)) ([6f80ed9](6f80ed9)), closes [#4200](#4200)
* **Forms:** ensure `Field.Number` with `percent` and without a value renders correctly ([#4230](#4230)) ([96fa2a5](96fa2a5)), closes [#4228](#4228)
* **Forms:** fix vertical gap between Field.ArraySelection toggle buttons with checkbox variant ([#4217](#4217)) ([83f0b37](83f0b37))
* **Forms:** remove extra space from Value.* components with `inline` property ([#4246](#4246)) ([8b96fd1](8b96fd1))
* **Forms:** should display error underneath fields when nested inside Field.Selection or Field.ArraySelection   ([#4225](#4225)) ([c0f1a02](c0f1a02))
* remove legacy `fieldset` reset ([#4237](#4237)) ([a2f368b](a2f368b))
* **Upload:** alignment when displaying single DL item ([#4210](#4210)) ([5f745f5](5f745f5))
* **Upload:** fix `UploadFile` type to include `id` as required ([#4218](#4218)) ([b24fdfd](b24fdfd))

### ✨ Features

* **Card:** add style for nested cards ([#4244](#4244)) ([f45aa4a](f45aa4a))
* **Card:** remove `beta` badge ([#4211](#4211)) ([67a4fbd](67a4fbd))
* **ChildrenWithAge:** add maximum possible value to joint-responsibility & daycare ([#4219](#4219)) ([9b9c517](9b9c517))
* **CountryFlag:** add iso to properties table ([#4232](#4232)) ([9dc57cb](9dc57cb))
* **DatePicker:** Convert to functional components with typescript and hooks ([#2799](#2799)) ([45687ea](45687ea))
* **Forms:** add `layoutOptions` for enhanced horizontal label layout ([#4208](#4208)) ([8d84d97](8d84d97))
* **Forms:** add `transformLabel` to Value.Composition ([#4207](#4207)) ([c966bc1](c966bc1))
* **Forms:** add `Value.Upload` component ([#4233](#4233)) ([3adddac](3adddac))
* **Forms:** add EditButton, CancelButton and DoneButton to Form.Section containers ([#4223](#4223)) ([092abcd](092abcd))
* **ListFormat:** add `ListFormat` component ([#4238](#4238)) ([63613f1](63613f1))
* **Upload:** add `download` prop to enable file downloads instead of opening in a new tab ([#4213](#4213)) ([3e92934](3e92934))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.55.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tujoworker tujoworker tujoworker approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langz @tujoworker