refactor(DatePicker): convert properties to camel case and deprecate those with snake case #4273

joakbjerk · 2024-11-12T18:06:42Z

Fix tests related to Fields using DatePicker

vercel · 2024-11-12T18:07:26Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
eufemia	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 13, 2024 2:50pm

codesandbox-ci · 2024-11-12T18:48:23Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

…e_case props)

packages/dnb-eufemia/src/components/date-picker/DatePickerAddon.tsx

packages/dnb-eufemia/src/components/date-picker/DatePickerDocs.ts

…n.tsx Co-authored-by: Anders <anderslangseth@gmail.com>

langz · 2024-11-13T13:21:34Z

packages/dnb-eufemia/src/shared/locales/nb-NO.ts

        day: 'd',
        month: 'm',
        year: 'å',
      },
+      // TODO: add firstDay


Is this to be done now, or at a later stage?

Thinking later stage, as it also leads to rewriting the firstDay default prop 🙏

langz · 2024-11-13T13:22:47Z

Unit tests is probably enough to test that this change works properly. Or should I test it manually as well?

…erience/eufemia into feat/date-picker-camel-case-props

joakbjerk · 2024-11-13T13:29:47Z

Unit tests is probably enough to test that this change works properly. Or should I test it manually as well?

I think just double checking that the portal documentation looks correct should be enough? 🤔 Since the unit tests should over functionality as you said 😁

langz · 2024-11-13T14:03:03Z

Is this still correct ?
https://eufemia-git-feat-date-picker-camel-case-props-eufemia.vercel.app/uilib/components/date-picker/events/

Or should it also be camelCased?

langz · 2024-11-13T14:04:57Z

When checking packages/dnb-design-system-portal/src/docs/uilib/components/date-picker/Examples.tsx, I see there's a good mix of props that's camelCased and other that's snake_cased, but that's probably just how it is in a transition face or so.

I find both start_date and startDate there

langz · 2024-11-13T14:05:48Z

Not important, but we could also update packages/dnb-eufemia/src/components/date-picker/stories/DatePicker.stories.tsx

joakbjerk · 2024-11-13T14:08:46Z

Is this still correct ? https://eufemia-git-feat-date-picker-camel-case-props-eufemia.vercel.app/uilib/components/date-picker/events/

Or should it also be camelCased?

Should be camel cased 😝

joakbjerk · 2024-11-13T14:11:50Z

When checking packages/dnb-design-system-portal/src/docs/uilib/components/date-picker/Examples.tsx, I see there's a good mix of props that's camelCased and other that's snake_cased, but that's probably just how it is in a transition face or so.

I find both start_date and startDate there

if it's snake casing in event objects, or shortcuts, then it's a symptom of the transition phase yeah, otherwise it's something that we forgot to convert 😁

langz · 2024-11-13T16:18:40Z

Should these changes result in the need to update a screenshot test?🤔

joakbjerk · 2024-11-13T16:24:26Z

Should these changes result in the need to update a screenshot test?🤔

Not the code changes, but it seems that changing the demo examples triggered a slight change in the height in the screenshot area itself 🤷

packages/dnb-eufemia/src/components/date-picker/__tests__/DatePicker.test.tsx

tujoworker

Really nice work 🚀

We should test this PR manually.

langz · 2024-11-15T07:36:48Z

In the example https://eufemia-git-feat-date-picker-camel-case-props-eufemia.vercel.app/uilib/components/date-picker/demos/#range-datepicker it's a bit annoying that we have both startDate and start_date, endDate and end_date,etc.

But I guess it's just something we need to have temporarily for now 👍

langz

I tested the Datepicker and Field.Date, and I could not find any anomalies

joakbjerk · 2024-11-15T07:41:34Z

I tested the Datepicker and Field.Date, and I could not find any anomalies

Sweet, thank you! 🎁

## [10.56.0](v10.55.1...v10.56.0) (2024-11-18) ### 🐛 Bug Fixes * **DatePicker:** ensure that `endMonth` does not fallback to `startMonth` when `endMonth` prop is defined ([#4254](#4254)) ([5281257](5281257)) * **Forms:** render given elements to `warning` and `info` properties ([#4261](#4261)) ([d60de25](d60de25)) ### ⚡ Refactoring * **DatePicker:** convert properties to camel case and deprecate those with snake case ([#4273](#4273)) ([a69a8aa](a69a8aa)) ### ✨ Features * **Field.Date:** add DatePickerProps ([#4160](#4160)) ([6a3765b](6a3765b)) * **Forms:** add `asyncFileHandler` to Field.Upload to support async file handling during upload ([#4281](#4281)) ([030a09c](030a09c)) * **Forms:** add inline HelpButton to all Field.* components as default (with option to open in Dialog) ([#4282](#4282)) ([e869a60](e869a60)) * **Forms:** add support for multiple info, warning and error messages given by an array ([#4284](#4284)) ([78f2fe8](78f2fe8)) * **ListFormat:** adds spacing properties ([#4255](#4255)) ([c72d999](c72d999)) * **Paragraph:** handle nested paragraphs (to be `span`'s) ([#4251](#4251)) ([ca3bbde](ca3bbde))

tujoworker · 2024-11-18T07:11:28Z

🎉 This PR is included in version 10.56.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

joakbjerk force-pushed the feat/date-picker-camel-case-props branch from bde67ea to 4bb0b4a Compare November 12, 2024 18:11

vercel bot had a problem deploying to Preview November 12, 2024 18:24 Failure

vercel bot had a problem deploying to Preview November 12, 2024 18:48 Failure

vercel bot had a problem deploying to Preview November 12, 2024 20:08 Failure

vercel bot had a problem deploying to Preview November 12, 2024 20:17 Failure

joakbjerk marked this pull request as ready for review November 12, 2024 20:40

joakbjerk requested review from tujoworker and langz November 12, 2024 20:40

vercel bot had a problem deploying to Preview November 12, 2024 20:46 Failure

joakbjerk changed the title ~~feat(DatePicker) covnvert properties to camel case~~ feat(DatePicker): covnvert properties to camel case Nov 12, 2024

langz changed the title ~~feat(DatePicker): covnvert properties to camel case~~ feat(DatePicker): convert properties to camel case Nov 13, 2024

tujoworker and others added 12 commits November 13, 2024 13:37

feat(DatePicker): convert to camelCase properties (and deprecate snak…

bd4e179

…e_case props)

convert snake_case to camelCase

8483504

camel case translations

2315d1d

re-add spacing props

6ea2319

add deprecated props warning

c0da511

update docs

e3995b5

update firstDay type

3a3665d

add comments

f3cf635

make sure translations and form element props get camelCased

3cfaab2

replace deprecated prop names

137af23

fix type errors

654fa8c

fix failing expiry tests

31885fe

joakbjerk force-pushed the feat/date-picker-camel-case-props branch from a6afd54 to 31885fe Compare November 13, 2024 12:37

vercel bot deployed to Preview November 13, 2024 12:53 View deployment

langz reviewed Nov 13, 2024

View reviewed changes

packages/dnb-eufemia/src/components/date-picker/DatePickerAddon.tsx Outdated Show resolved Hide resolved

langz reviewed Nov 13, 2024

View reviewed changes

packages/dnb-eufemia/src/components/date-picker/DatePickerDocs.ts Outdated Show resolved Hide resolved

Update packages/dnb-eufemia/src/components/date-picker/DatePickerAddo…

01a1f6e

…n.tsx Co-authored-by: Anders <anderslangseth@gmail.com>

vercel bot deployed to Preview November 13, 2024 13:15 View deployment

langz approved these changes Nov 13, 2024

View reviewed changes

joakbjerk added 2 commits November 13, 2024 14:27

update demo examples

520f4c4

Merge branch 'feat/date-picker-camel-case-props' of github.com:dnbexp…

5ab4073

…erience/eufemia into feat/date-picker-camel-case-props

vercel bot deployed to Preview November 13, 2024 13:36 View deployment

remove old event table

f4c97ad

update stories

0a673ed

vercel bot deployed to Preview November 13, 2024 14:18 View deployment

update screenshot test

dda910a

vercel bot deployed to Preview November 13, 2024 14:50 View deployment

tujoworker changed the title ~~feat(DatePicker): convert properties to camel case~~ refactor(DatePicker): convert properties to camel case and deprecate those with snake case Nov 14, 2024

tujoworker reviewed Nov 14, 2024

View reviewed changes

packages/dnb-eufemia/src/components/date-picker/__tests__/DatePicker.test.tsx Show resolved Hide resolved

tujoworker approved these changes Nov 14, 2024

View reviewed changes

langz approved these changes Nov 15, 2024

View reviewed changes

joakbjerk merged commit a69a8aa into main Nov 15, 2024
10 checks passed

joakbjerk deleted the feat/date-picker-camel-case-props branch November 15, 2024 07:41

tujoworker added the released label Nov 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(DatePicker): convert properties to camel case and deprecate those with snake case #4273

refactor(DatePicker): convert properties to camel case and deprecate those with snake case #4273

joakbjerk commented Nov 12, 2024 •

edited

Loading

vercel bot commented Nov 12, 2024 •

edited

Loading

codesandbox-ci bot commented Nov 12, 2024 •

edited

Loading

langz Nov 13, 2024

joakbjerk Nov 13, 2024

langz commented Nov 13, 2024

joakbjerk commented Nov 13, 2024 •

edited

Loading

langz commented Nov 13, 2024

langz commented Nov 13, 2024

langz commented Nov 13, 2024

joakbjerk commented Nov 13, 2024

joakbjerk commented Nov 13, 2024

langz commented Nov 13, 2024

joakbjerk commented Nov 13, 2024

tujoworker left a comment

langz commented Nov 15, 2024

langz left a comment

joakbjerk commented Nov 15, 2024

tujoworker commented Nov 18, 2024

refactor(DatePicker): convert properties to camel case and deprecate those with snake case #4273

refactor(DatePicker): convert properties to camel case and deprecate those with snake case #4273

Conversation

joakbjerk commented Nov 12, 2024 • edited Loading

vercel bot commented Nov 12, 2024 • edited Loading

codesandbox-ci bot commented Nov 12, 2024 • edited Loading

langz Nov 13, 2024

Choose a reason for hiding this comment

joakbjerk Nov 13, 2024

Choose a reason for hiding this comment

langz commented Nov 13, 2024

joakbjerk commented Nov 13, 2024 • edited Loading

langz commented Nov 13, 2024

langz commented Nov 13, 2024

langz commented Nov 13, 2024

joakbjerk commented Nov 13, 2024

joakbjerk commented Nov 13, 2024

langz commented Nov 13, 2024

joakbjerk commented Nov 13, 2024

tujoworker left a comment

Choose a reason for hiding this comment

langz commented Nov 15, 2024

langz left a comment

Choose a reason for hiding this comment

joakbjerk commented Nov 15, 2024

tujoworker commented Nov 18, 2024

joakbjerk commented Nov 12, 2024 •

edited

Loading

vercel bot commented Nov 12, 2024 •

edited

Loading

codesandbox-ci bot commented Nov 12, 2024 •

edited

Loading

joakbjerk commented Nov 13, 2024 •

edited

Loading