fix(Autocomplete): support query with unicodes when using search_numbers
#4419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tujoworker
reviewed
Dec 19, 2024
packages/dnb-eufemia/src/components/autocomplete/Autocomplete.js
Outdated
Show resolved
Hide resolved
tujoworker
reviewed
Dec 19, 2024
packages/dnb-eufemia/src/components/autocomplete/Autocomplete.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Tobias Høegh <tobias@tujo.no>
Co-authored-by: Tobias Høegh <tobias@tujo.no>
langz
changed the title
search_numbers
langz
changed the title
search_numberssearch_numbers
tujoworker
pushed a commit
that referenced
this pull request
Dec 20, 2024
## [10.62.0](v10.61.0...v10.62.0) (2024-12-20) ### 🔁 CI * upgrade playwright ([#4413](#4413)) ([27f2106](27f2106)) ### ✨ Features * **Forms:** add `label` and `showLabel` prop to Form.SubmitIndicator ([#4409](#4409)) ([95af6e3](95af6e3)) * **Forms:** add `update` method to `Form.setData` ([#4416](#4416)) ([d2f5c23](d2f5c23)) * **Forms:** show a label along the indicator for async field processes ([#4410](#4410)) ([885ae0d](885ae0d)), closes [#4409](#4409) ### 🐛 Bug Fixes * **Autocomplete:** support query with unicodes when using `search_numbers` ([#4419](#4419)) ([f19b7da](f19b7da))
|
🎉 This PR is included in version 10.62.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4293
As of now, I've just added support for the characters ÆØÅ, not sure if there's other non-alphanumeric characters we should support, and perhaps improve the regex to something better than just
\wÆØÅæøå.Original CSB from the issue
CSB with the fix using commit aa28f0c
CSB with the fix using commit 2334c87